Repository navigation
Make breeze verify tests pass on release branches - #74624
Merged
Merged
Conversation
The breeze verify command (#73241) derives the base ref and the selective-checks default_branch from branch_defaults.AIRFLOW_BRANCH, but its tests hardcode "main". On a vX-Y-test release branch - where AIRFLOW_BRANCH is e.g. "v3-4-test" - the base-ref lookup, the no-apache-remote fallback, and the docs list all differ, so eight tests fail. v3-4-test is the first release branch to include the command and surface this. Pin AIRFLOW_BRANCH / DEFAULT_AIRFLOW_CONSTRAINTS_BRANCH to main / constraints-main in an autouse fixture so the suite asserts the main behaviour it was written for, on any branch.
vatsrahul1001
requested review from
amoghrajesh,
ashb,
bugraoz93,
choo121600,
ephraimbuddy,
gopidesupavan,
jason810496,
jedcunningham,
jscheffl and
potiuk
as code owners
October 13, 2026 06:44
ephraimbuddy
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
breeze verifycommand (added in #73241) derives the base ref and the selective-checksdefault_branchfrombranch_defaults.AIRFLOW_BRANCH. Its tests intest_verify_commands.py, however, hardcode"main".On
mainthat's fine, but on avX-Y-testrelease branch — whereAIRFLOW_BRANCHis e.g."v3-4-test"— three things shift and 8 tests fail:find_default_base_ref()looks for<remote>/v3-4-testinstead of<remote>/main;base_ref = AIRFLOW_BRANCH) isv3-4-test, notmain;default_branch=AIRFLOW_BRANCHpassed to selective checks changes the docs list (e.g.build-docs apache-airflow docker-stack).v3-4-testis the first release branch to fast-forward in this command, so it's the first to surface it (patch branches likev3-3-testonly get cherry-picks and don't have the command yet).The fix pins
AIRFLOW_BRANCH/DEFAULT_AIRFLOW_CONSTRAINTS_BRANCHtomain/constraints-mainin an autouse fixture, so the suite asserts themainbehaviour it was written for regardless of which branch it runs on. Verified: the previously-failing 8 tests pass onv3-4-test(realAIRFLOW_BRANCH="v3-4-test"), and all 23 still pass onmain.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.8) following the guidelines