Repository navigation
Highlight YAML Dag source in the Code tab - #74633
Merged
Merged
Conversation
The AIP-85 YAML importer (apache#74586) stores its Dag source with language "yaml", but the Code tab's Monaco setup only registers the Python, TypeScript, Java and Go grammars, so YAML Dags rendered as plain text. Register Monaco's YAML grammar the same way as the others.
pierrejeambrun
force-pushed
the
highlight-yaml-dag-source
branch
from
October 13, 2026 09:24
b5ba0b1 to
ce56954
Compare
pierrejeambrun
marked this pull request as ready for review
October 13, 2026 09:28
pierrejeambrun
requested review from
bbovenzi,
choo121600,
guan404ming,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
October 13, 2026 09:28
uranusjr
approved these changes
Oct 13, 2026
1 task done
Member
Author
|
Unrelated CI failure. Merging. |
Contributor
Backport successfully created: v3-4-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
vatsrahul1001
pushed a commit
that referenced
this pull request
Oct 18, 2026
The AIP-85 YAML importer (#74586) stores its Dag source with language "yaml", but the Code tab's Monaco setup only registers the Python, TypeScript, Java and Go grammars, so YAML Dags rendered as plain text. Register Monaco's YAML grammar the same way as the others. (cherry picked from commit f6f267d) Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
vatsrahul1001
pushed a commit
that referenced
this pull request
Oct 20, 2026
The AIP-85 YAML importer (#74586) stores its Dag source with language "yaml", but the Code tab's Monaco setup only registers the Python, TypeScript, Java and Go grammars, so YAML Dags rendered as plain text. Register Monaco's YAML grammar the same way as the others. (cherry picked from commit f6f267d) Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AIP-85 YAML importer (#74586) stores a YAML Dag's source with language
yaml, butconfigureMonacoonly registers the Python, TypeScript, Java and Go grammars, so YAML Dags showed up as unhighlighted plain text in the Code tab.Registers Monaco's YAML grammar exactly like the other Dag-authoring languages (dynamic import of the grammar module, same
conf/languageruntime shape guard, ambient module declaration) and adds it to the grammar export-shape test.Before
After
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Claude Opus 5.5) following the guidelines