Skip to content

Keep parent DAG folders collapsed after one click - #75079

Merged
bbovenzi merged 1 commit into
apache:mainfrom
himanshuchawla0807-gif:fix/dag-folder-collapse
Oct 19, 2026
Merged

bbovenzi merged 1 commit into
apache:mainfrom
himanshuchawla0807-gif:fix/dag-folder-collapse

Conversation

@himanshuchawla0807-gif

Copy link
Copy Markdown
Contributor

When a child folder is selected, clicking its parent collapses the branch and selects the parent, but selection auto-expansion immediately opens it again. Expand only ancestors of the selected node so the first click leaves the parent collapsed. This also covers collapsing a bundle and an empty folder query parameter.

closes: #75068

Validation:

  • All three regression cases fail on unchanged upstream; folder-tree suites pass with the fix (29 tests).
  • Actual component browser check confirms the first parent click stays collapsed; nested initial selections still expand their ancestors. This is component validation, not a deployed Airflow end-to-end test.
  • Scoped ESLint, TypeScript, commit hooks and required manual checks pass, including both UI builds.
  • Full UI suite: 1,963 tests pass across 239 files using pnpm test --maxWorkers=2 --testTimeout=30000; simple-auth UI test also passes. Earlier runs hit unrelated five-second timeouts on a heavily loaded Mac; no assertions or repository timeout settings were changed.

Before/after component screenshots (same single parent click):

Before After
Parent reopens after the first click Parent stays collapsed after the first click

Was generative AI tooling used to co-author this PR?
  • Yes — OpenAI Codex

Generated-by: OpenAI Codex following the guidelines

@boring-cyborg boring-cyborg Bot added the area:UI Related to UI/UX. For Frontend Developers. label Oct 19, 2026
@vatsrahul1001 vatsrahul1001 added this to the Airflow 3.4.0 milestone Oct 19, 2026
@vatsrahul1001 vatsrahul1001 added the backport-to-v3-4-test Backport to v3-4-test label Oct 19, 2026
@bbovenzi
bbovenzi merged commit c1b2552 into apache:main Oct 19, 2026
78 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-4-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
✅ v3-4-test PR Link

vatsrahul1001 added a commit that referenced this pull request Oct 20, 2026
#75145)

(cherry picked from commit c1b2552)

Co-authored-by: Himanshu Chawla <himanshuchawla0807@gmail.com>
Co-authored-by: Himanshu Chawla <241715894+himanshuchawla0807-gif@users.noreply.github.com>
Co-authored-by: Rahul Vats <43964496+vatsrahul1001@users.noreply.github.com>
vatsrahul1001 added a commit that referenced this pull request Oct 20, 2026
#75145)

(cherry picked from commit c1b2552)

Co-authored-by: Himanshu Chawla <himanshuchawla0807@gmail.com>
Co-authored-by: Himanshu Chawla <241715894+himanshuchawla0807-gif@users.noreply.github.com>
Co-authored-by: Rahul Vats <43964496+vatsrahul1001@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. backport-to-v3-4-test Backport to v3-4-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to Collapse Parent Folder in a Single Click When a Child Folder Is Selected

3 participants