Repository navigation
[v3-4-test] Mock the simple auth manager in permission tests and guard against the base-class patch (#75138) - #75140
Merged
Conversation
…d against the base-class patch (apache#75138) Only the check-auth-manager-mock-targets prek hook applies here: the dependencies graph permission tests from apache#73008 are not on v3-4-test, and the upstream asset events test from apache#72924 already patches SimpleAuthManager on this branch. (cherry picked from commit ac0c20c) Generated-by: Claude Opus 5
potiuk
requested review from
amoghrajesh,
ashb,
bugraoz93,
gopidesupavan,
jason810496 and
jscheffl
as code owners
October 19, 2026 20:45
vatsrahul1001
pushed a commit
that referenced
this pull request
Oct 20, 2026
…d against the base-class patch (#75138) (#75140) Only the check-auth-manager-mock-targets prek hook applies here: the dependencies graph permission tests from #73008 are not on v3-4-test, and the upstream asset events test from #72924 already patches SimpleAuthManager on this branch. (cherry picked from commit ac0c20c) Generated-by: Claude Opus 5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #75138 to
v3-4-test.Only the
check-auth-manager-mock-targetsprek hook (with its tests and config entry) applies here: the dependencies graph permission tests from #73008 are not onv3-4-test, and the upstream asset events test from #72924 already patchesSimpleAuthManageron this branch.SimpleAuthManageroverridesget_authorized_assetsonv3-4-testtoo, so the guard is just as relevant for future backports.On
v3-4-test: the hook's tests pass (9), and the hook passes over all files.(cherry picked from commit ac0c20c)
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 5) following the guidelines