Skip to content

Fix stale-session assertion in mapped placeholder promotion test #75175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vatsrahul1001 merged 1 commit into from
Oct 20, 2026
Merged

Fix stale-session assertion in mapped placeholder promotion test #75175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions airflow-core/tests/unit/models/test_mappedoperator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2235,10 +2235,9 @@ def test_zero_length_expansion_leaves_a_region_holding_only_its_skipped_placehol
assert placeholder.state == TaskInstanceState.SKIPPED


def test_promotion_leaves_earlier_placeholder_task_instances_at_their_coordinates(mapped_dag, session):
def test_promotion_deletes_earlier_placeholder_task_instances(mapped_dag, session):
dr, serialized, upstream_id = mapped_dag
placeholder = _live_tis(session, dr, serialized.task_id)[0]
region_id = placeholder.region_id
placeholder.task = serialized
placeholder.try_number = 1
placeholder.state = TaskInstanceState.FAILED
Expand All @@ -2249,9 +2248,16 @@ def test_promotion_leaves_earlier_placeholder_task_instances_at_their_coordinate

expand_mapped_task(serialized, dr.run_id, upstream_id, 2, session)

archived = session.get(TaskInstance, archived_id)
assert (archived.region_id, archived.region_index, archived.try_number) == (region_id, -1, 1)
assert archived.working_set is None
# The delete doesn't synchronize the session, so read the database rather than the identity map.
session.expire_all()
assert (
session.scalar(
select(TaskInstance.id)
.where(TaskInstance.id == archived_id)
.execution_options(include_all_attempts=True)
)
is None
)
live = _live_tis(session, dr, serialized.task_id)
assert [ti.region_index for ti in live] == [0, 1]
assert live[0].id == current.id
Expand Down