Repository navigation
[v3-4-test] Fix stale-session assertion in mapped placeholder promotion test (#75175) - #75181
Merged
Merged
Conversation
…on test (#75175) test_promotion_leaves_earlier_placeholder_task_instances_at_their_coordinates asserted that the archived -1 attempt of a mapped task survives expansion. Since #74407 expansion deletes those attempts, but the delete runs with synchronize_session=False, so session.get() kept returning the stale identity-map object and the test passed while asserting the opposite of what the database holds. Expire the session and query the database, asserting the archived placeholder attempt is gone, and rename the test to match. (cherry picked from commit 11ed204) Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
Contributor
Author
|
Hi maintainer, this PR was merged without a milestone set.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_promotion_leaves_earlier_placeholder_task_instances_at_their_coordinates
asserted that the archived -1 attempt of a mapped task survives expansion.
Since #74407 expansion deletes those attempts, but the delete runs with
synchronize_session=False, so session.get() kept returning the stale
identity-map object and the test passed while asserting the opposite of
what the database holds.
Expire the session and query the database, asserting the archived
placeholder attempt is gone, and rename the test to match.
(cherry picked from commit 11ed204)
Co-authored-by: Jed Cunningham 66968678+jedcunningham@users.noreply.github.com