Repository navigation
[v3-4-test] Revert "Enforce execution_timeout for tasks run by a language SDK" (#75376) - #75469
Merged
Merged
Conversation
…uage SDK (apache#74869)" (apache#75376) This reverts commit 8326025. 3.4.0 closes today and apache#75376 needs apache#75387 alongside it, which needs more bandwidth than is left. On v3-4-test alone, the Python task runner arms SIGALRM from task.execution_timeout while the supervisor arms its deadline from TIRunContext.execution_timeout. When the server value is smaller, the supervisor sends SIGTERM before the runner raises AirflowTaskTimeout, so on_kill, the retry policy, callbacks and listeners are skipped. Reverting avoids shipping that regression in 3.4.0. apache#74869 stays on main. SetExecutionTimeout (apache#73806) is untouched, so Python tasks keep the supervisor backstop they had before apache#75376. Co-Authored-By: Claude <noreply@anthropic.com>
boring-cyborg
Bot
added
area:API
jason810496
marked this pull request as ready for review
October 23, 2026 12:59
jason810496
requested review from
amoghrajesh,
ashb,
bolkedebruin,
kaxil and
uranusjr
as code owners
October 23, 2026 12:59
vatsrahul1001
approved these changes
Oct 23, 2026
Contributor
|
Hi maintainer, this PR was merged without a milestone set.
|
1 task done
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #75376 on
v3-4-testonly. #74869 stays onmain.3.4.0 closes today, and #75376 needs #75387 alongside it to be correct. Getting #75387 in needs more bandwidth than is left, so it is safer to take #75376 out of the release than to ship half the pair.
The regression it leaves behind, from the review in #75387 (review): on
v3-4-testthe Python task runner arms SIGALRM fromtask.execution_timeout, while the supervisor arms its deadline fromTIRunContext.execution_timeout. When the server value is the smaller one, for example a differentdefault_task_execution_timeout, a Dag file changed after serialization,pre_execute, or a mappedexpand(execution_timeout=...), the supervisor sends SIGTERM before the runner raisesAirflowTaskTimeout, soon_kill, the retry policy, callbacks and listeners are all skipped.git revertapplies with no conflicts, and all 29 files land byte-identical to their state before #75376.SetExecutionTimeoutfrom #73806 is untouched, so Python tasks keep the supervisor backstop they had before.Was generative AI tooling used to co-author this PR?