Repository navigation
fix(java/driver/jni): release ADBC resources on Java constructor failure - #4396
Merged
Merged
Conversation
…lure When NewObject fails, explicitly call AdbcFooRelease or foo->release instead of implicitly leaking the ADBC handle. Assisted-by: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR hardens the Java JNI driver against native resource leaks when constructing Java “native handle/result” objects fails, ensuring ADBC/Arrow C resources are explicitly released instead of being silently leaked.
Changes:
- Add explicit
Adbc*Releasecalls on failure paths inopenDatabase,openConnection, andopenStatement(notably whenNewObjectfails). - Add failure-safe cleanup in
MakeNativeQueryResult/MakeNativeSchemaResultto releaseArrowArrayStream/ArrowSchemawhen Java object construction fails.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lidavidm
marked this pull request as ready for review
June 15, 2026 03:04
zeroshade
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When NewObject fails, explicitly call AdbcFooRelease or foo->release instead of implicitly leaking the ADBC handle.
Assisted-by: Claude Opus 4.8 noreply@anthropic.com