Repository navigation
chore(dev/release): fix verification issues - #4937
Merged
Merged
Conversation
Member
Author
amoeba
reviewed
Oct 22, 2026
| adbc_*-cp${pyver/.}-cp${python/.}-${platform}*${arch}*.whl \ | ||
| adbc_*-py3-none-${platform}*${arch}*.whl | ||
| ${ADBC_DIR}/ci/scripts/python_wheel_unix_test.sh ${ADBC_DIR} | ||
| unset PYTHON_GIL |
Member
There was a problem hiding this comment.
This seems out of place but safe.
Member
Author
There was a problem hiding this comment.
Ah, it turns out that the Conda environment activate/deactivate was barfing if it was set.
amoeba
reviewed
Oct 22, 2026
Comment on lines
+969
to
+976
| local test_arguments=() | ||
| if [[ "$(uname)" == "Darwin" && "$(uname -m)" == "x86_64" ]]; then | ||
| show_info "Skipping testDriverJni: JNI binaries are not available for macOS/x86_64" | ||
| test_arguments+=('-Dtest=!VerifyReleaseCandidateTest#testDriverJni') | ||
| fi | ||
|
|
||
| mvn "${maven_arguments[@]}" test \ | ||
| "${test_arguments[@]}" \ |
Member
There was a problem hiding this comment.
Would this be cleaner if we put this in the Java test?
diff --git a/dev/release/verify-release-candidate.sh b/dev/release/verify-release-candidate.sh
index 3c8e123f2..c59fa0fdc 100755
--- a/dev/release/verify-release-candidate.sh
+++ b/dev/release/verify-release-candidate.sh
@@ -966,14 +966,7 @@ print(version.text)
"-Djavadoc=${javadoc_path}"
done
- local test_arguments=()
- if [[ "$(uname)" == "Darwin" && "$(uname -m)" == "x86_64" ]]; then
- show_info "Skipping testDriverJni: JNI binaries are not available for macOS/x86_64"
- test_arguments+=('-Dtest=!VerifyReleaseCandidateTest#testDriverJni')
- fi
-
mvn "${maven_arguments[@]}" test \
- "${test_arguments[@]}" \
"-Dadbc.version=${java_version}" \
-f "${SOURCE_DIR}/verify/java/pom.xml"
}
diff --git a/dev/release/verify/java/src/test/java/org/apache/arrow/adbc/verify/VerifyReleaseCandidateTest.java b/dev/release/verify/java/src/test/java/org/apache/arrow/adbc/verify/VerifyReleaseCandidateTest.java
index 83f6d5512..03c4abfcc 100644
--- a/dev/release/verify/java/src/test/java/org/apache/arrow/adbc/verify/VerifyReleaseCandidateTest.java
+++ b/dev/release/verify/java/src/test/java/org/apache/arrow/adbc/verify/VerifyReleaseCandidateTest.java
@@ -85,6 +85,17 @@ class VerifyReleaseCandidateTest {
@Test
void testDriverJni() {
var driver = new JniDriver(allocator);
+ if (OS.MAC.isCurrentOs() && "x86_64".equalsIgnoreCase(System.getProperty("os.arch"))) {
+ // JNI binaries are not available for macOS x86_64.
+ ExceptionInInitializerError exception =
+ assertThrows(
+ ExceptionInInitializerError.class, () -> driver.load().driver("nonexistent").open());
+ assertThat(exception)
+ .hasRootCauseInstanceOf(RuntimeException.class)
+ .hasRootCauseMessage("ADBC JNI driver not supported on architecture x86_64");
+ return;
+ }
+
if (OS.WINDOWS.isCurrentOs() && "aarch64".equalsIgnoreCase(System.getProperty("os.arch"))) {
// JNI binaries are not available for Windows ARM64.
ExceptionInInitializerError exception =
Member
Author
There was a problem hiding this comment.
It would, but then I'd have to cut the release from scratch
Member
Author
There was a problem hiding this comment.
Want to file an issue and we can get this fixed for the next release?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assisted-by: GPT-6 Astra