Skip to content

chore: move JNI verification test selection into Java test #4943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lidavidm merged 1 commit into from
Oct 26, 2026
+11 −7
Merged

chore: move JNI verification test selection into Java test #4943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions dev/release/verify-release-candidate.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -966,14 +966,7 @@ print(version.text)
"-Djavadoc=${javadoc_path}"
done

local test_arguments=()
if [[ "$(uname)" == "Darwin" && "$(uname -m)" == "x86_64" ]]; then
show_info "Skipping testDriverJni: JNI binaries are not available for macOS/x86_64"
test_arguments+=('-Dtest=!VerifyReleaseCandidateTest#testDriverJni')
fi

mvn "${maven_arguments[@]}" test \
"${test_arguments[@]}" \
"-Dadbc.version=${java_version}" \
-f "${SOURCE_DIR}/verify/java/pom.xml"
}
Expand Down
11 changes: 11 additions & 0 deletions ...se/verify/java/src/test/java/org/apache/arrow/adbc/verify/VerifyReleaseCandidateTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,17 @@ void testDriverJdbcAdapter() throws Exception {
@Test
void testDriverJni() {
var driver = new JniDriver(allocator);
if (OS.MAC.isCurrentOs() && "x86_64".equalsIgnoreCase(System.getProperty("os.arch"))) {
// JNI binaries are not available for macOS x86_64.
ExceptionInInitializerError exception =
assertThrows(
ExceptionInInitializerError.class, () -> driver.load().driver("nonexistent").open());
assertThat(exception)
.hasRootCauseInstanceOf(RuntimeException.class)
.hasRootCauseMessage("ADBC JNI driver not supported on architecture x86_64");
return;
}

if (OS.WINDOWS.isCurrentOs() && "aarch64".equalsIgnoreCase(System.getProperty("os.arch"))) {
// JNI binaries are not available for Windows ARM64.
ExceptionInInitializerError exception =
Expand Down
Loading