Repository navigation
chore: update versions for 26-SNAPSHOT, add changelog for 25 - #4954
Merged
Merged
Conversation
This was referenced Oct 26, 2026
Member
|
JavaScript failure should be solved by running |
lidavidm
pushed a commit
that referenced
this pull request
Oct 26, 2026
In #4954 we saw the Lint/CheckJS job fail: ``` Checking formatting... [warn] npm/darwin-arm64/package.json [warn] npm/darwin-x64/package.json [warn] npm/linux-arm64-gnu/package.json [warn] npm/linux-x64-gnu/package.json [warn] npm/win32-arm64-msvc/package.json [warn] npm/win32-x64-msvc/package.json [warn] Code style issues found in 6 files. Run Prettier with --write to fix. Error: Process completed with exit code 1. ``` In dev/release/utils-prepare.sh we run `npx --yes napi version` which, when it writes out new `package.json` files, doesn't add trailing newlines. I think we should reformat after we run `napi` so this PR adds an `npm run fix` after we run `napi version` so the result of `napi` passes our lint step.
lidavidm
marked this pull request as ready for review
October 27, 2026 02:27
lidavidm
requested review from
CurtHagenlocher,
kou,
paleolimbot and
wjones127
as code owners
October 27, 2026 02:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.