Repository navigation
Conversation
adamreeve
reviewed
Oct 21, 2026
adamreeve
left a comment
Contributor
There was a problem hiding this comment.
Thanks for addressing this @ump45nose
| using Apache.Arrow; | ||
| using Apache.Arrow.Ipc; | ||
|
|
||
| public static async Task<RecordBatch> ReadArrowAsync(string filename) |
Contributor
There was a problem hiding this comment.
Can you please add a short description of what this example does. Eg. "Example of reading an Arrow IPC file".
Also, this example only reads the first batch of data from the file. It could mislead people if they copy this code, thinking it will read a whole file. Maybe it should return a List<RecordBatch> instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
dotnet nuget pushwarns that our packages have no readme. This adds a short package readme (src/README.md) and wires it up in the shared NuGet properties inDirectory.Build.props(PackageReadmeFileplus a packedContentitem next to the license and icon), so every packable project undersrc/gets it.The root
README.mdis aimed at people building the repo (build steps, relative links to source folders), so I wrote a separate, smaller one for nuget.org: what Apache Arrow is, the list of packages, a short IPC reading example and links to the docs and the repository. All links are absolute so they work on nuget.org. It carries the usual ASF license header like the other Markdown files.Checked with
dotnet pack -c Releasefor each project insrc/: all seven.nupkgfiles now containREADME.mdat the package root and their nuspec has<readme>README.md</readme>, with no new pack warnings.This PR was prepared with AI assistance and reviewed by me.
Closes #45.