Repository navigation
ci: use cargo machete for dependency checks - #11189
Closed
efegokdemir wants to merge 1 commit into
Closed
efegokdemir wants to merge 1 commit into
efegokdemir wants to merge 1 commit into
Conversation
Signed-off-by: Efe Gökdemir <efe@rexcode.co.uk>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Replace the repeated
unused_crate_dependenciesClippy checks with a dedicatedcargo macheteworkflow. This makes dependency checking workspace-wide and includes dependencies used by tests and benches, as requested in #11166.Changes
cargo-machete0.9.2.cargo machete --with-metadatafor the complete workspace.Testing
cargo machete: passed; no unused dependencies detected.yamllint -d relaxed .github/workflows/arrow.yml .github/workflows/integration.yml .github/workflows/dependencies.yml: passed with existing line-length warnings.git diff --check: passed.cargo machete --with-metadata: attempted locally, but the offline environment lacks cached workspace dependencies; the command completed with dependency-download errors. The CI workflow runs in a populated container and uses the same command.Notes
taiki-e/install-actionalready used by Apache DataFusion for this tool.Fixes #11166