Repository navigation
GH-54649: [C++][FlightRPC][ODBC] Fetch on the current connection for arrow-flight-reuse-connection locations - #54652
Open
AbhishekPathania wants to merge 1 commit into
Conversation
…n for arrow-flight-reuse-connection locations
|
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused fix matches the endpoint contract and includes a targeted regression test; no blocking issues were identified.
No open issues 🎉
What changed in this PR
Fixes ODBC result fetching for servers that return arrow-flight-reuse-connection endpoint locations, addressing GH-54649.
Changes:
- Uses the existing client when the first endpoint location specifies connection reuse.
- Clarifies the client-lifetime comment and adds a regression test expecting five chunks.
| File | Description |
|---|---|
| cpp/src/arrow/flight/sql/odbc/odbc_impl/flight_sql_stream_chunk_buffer.cc | Handles reuse-connection locations using the existing client. |
| cpp/src/arrow/flight/sql/odbc/odbc_impl/flight_sql_stream_chunk_buffer_test.cc | Adds coverage for fetching through a reuse-connection endpoint. |
Review effort: Balanced
shahriyar-novruzov
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Flight servers can return
arrow-flight-reuse-connection://?as an endpoint location (GH-40345) to mean "fetch on the current connection". The ODBC driver passes it toFlightClient::Connect, which fails with "No client transport implementation for arrow-flight-reuse-connection". Result sets andSQLGetInfo, including the DSN dialog's Test Connection, fail against such servers.What changes are included in this PR?
FlightStreamChunkBuffertreats an endpoint whose first location uses the reuse-connection scheme the same as an endpoint with no locations, and callsDoGeton the existing client. The JDBC driver handles it the same way.Are these changes tested?
Yes.
FlightStreamChunkBufferTest.TestReuseConnectionLocationfails without the fix.Are there any user-facing changes?
The ODBC driver can read results from servers that return the reuse-connection location.
Was AI used for this PR?
PR code and description written by:
Reviewed before submission by:
arrow-flight-reuse-connection://?#54649