Update pmd config to make it pmd 7 compatible#13168
Draft
vishesh92 wants to merge 1 commit into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.20 #13168 +/- ##
============================================
- Coverage 16.27% 16.26% -0.01%
+ Complexity 13440 13437 -3
============================================
Files 5665 5665
Lines 500555 500555
Branches 60789 60789
============================================
- Hits 81445 81439 -6
- Misses 410004 410011 +7
+ Partials 9106 9105 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
@blueorangutn package |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates CloudStack’s PMD ruleset configuration to align with PMD 7’s category/ruleset structure, and adjusts codespell allowlist to avoid false positives from PMD’s “errorprone” category naming.
Changes:
- Replaced the legacy PMD category references with PMD 7 category rulesets and consolidated exclusions into the new category structure.
- Added
errorproneto the codespell dictionary exceptions to prevent CI/lint noise for the PMD 7 category name.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tools/checkstyle/src/main/resources/cloud-pmd.xml | Migrates the PMD ruleset to PMD 7 category files and redefines project-specific exclusions under those categories. |
| .github/linters/codespell.txt | Allows the term errorprone to avoid codespell flagging PMD 7’s category name. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates pmd config to make it pmd 7 compatible
mvnd clean install -P developer,systemvm -DskipTests=true # Generates pmd.xml in target directory for modules with errors. mvnd pmd:check -P developer,systemvm -DskipTests=trueRef: https://docs.pmd-code.org/pmd-doc-7.0.0-rc2/pmd_rules_java.html#best-practices
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?