fix: Projection stats were Absent for columns referenced >1 time#22679
Open
neilconway wants to merge 1 commit into
Open
fix: Projection stats were Absent for columns referenced >1 time#22679neilconway wants to merge 1 commit into
neilconway wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Absentfor columns referenced >1 time #22678.Rationale for this change
ProjectionExprs::project_statisticsusesstd::mem::taketo move an input column'sColumnStatisticsinto the output when given a direct column reference. This means if the column is referenced again (either directly or in aCASTexpression), the statistics areAbsent. The simple fix is to justcloneinstead oftake.This pattern crops up in TPC-DS q54, which includes a CTE that projects both
d_date_skandCAST(d_date_sk AS Float64), but it's a more general bug.What changes are included in this PR?
Are these changes tested?
Yes; new test added.
Are there any user-facing changes?
No.