FELIX-6836: Mitigate Zip Slip / Path Traversal (CWE-22) Vulnerability in Archive Extraction and Cache Handlers#516
Open
sahvx655-wq wants to merge 3 commits into
Open
Conversation
Contributor
|
@sahvx655-wq before you start creating more PR's, let's first establish what the problem is you're trying to solve. Can you start there first and create tickets for the things you're trying to address? |
added 3 commits
June 16, 2026 12:53
sahvx655-wq
force-pushed
the
mitigate-zip-slip
branch
from
3d0f049 to
0f42095
Compare
sahvx655-wq
changed the title
Author
|
I have created the Jira ticket for this issue here : https://issues.apache.org/jira/browse/FELIX-6836 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prevents Zip Slip / Path Traversal issues during ZIP and JAR archive extraction by validating archive entry paths before writing files to disk. Entries that would resolve outside the intended extraction directory are rejected, ensuring extraction remains confined to the target location.
In addition to the implementation changes, regression tests have been added to verify that malicious archives containing traversal entries (for example,
../../evil.txt) are rejected and cause extraction to fail safely.