Repository navigation
[kafka] Miscellaneous Kafka compatibility improvements - #4865
Merged
Merged
Conversation
Member
|
License build is failed, please check it. |
wuchong
reviewed
Oct 26, 2026
gyang94
force-pushed
the
codex/kafka-misc
branch
from
October 26, 2026 10:50
c2563f3 to
3d04849
Compare
Add dynamic service admission, ordered draining and non-retryable disabled responses. Preserve compressed-record diagnostics and package Kafka clients with server-provided codecs. Consolidate tests and document the lifecycle. Co-Authored-By: Codex <noreply@openai.com> AI-Model: gpt-6 AI-Contributed/Feature: 772/773 AI-Contributed/UT: 2001/2001
Co-Authored-By: Codex <noreply@openai.com> AI-Model: gpt-6 AI-Contributed/Feature: 19/19 AI-Contributed/UT: 0/0
Preserve the Kafka NOTICE under META-INF and exclude duplicate root legal files. Co-Authored-By: Codex <noreply@openai.com> AI-Model: gpt-6 AI-Contributed/Feature: 34/34 AI-Contributed/UT: 0/0
Move service switching instructions under cluster configuration and explain client behavior in user-facing terms. Remove packaging implementation details. Co-Authored-By: Codex <noreply@openai.com> AI-Model: gpt-6 AI-Contributed/Feature: 30/30 AI-Contributed/UT: 0/0
Keep admission checks at dispatch, backend entry, and locked native submission. Remove repeated checks from Produce parsing and per-partition conversion. Co-Authored-By: Codex <noreply@openai.com> AI-Model: gpt-6 AI-Contributed/Feature: 4/4 AI-Contributed/UT: 0/0
gyang94
force-pushed
the
codex/kafka-misc
branch
from
October 26, 2026 12:28
3d04849 to
e283aeb
Compare
Treat Kafka enablement as a best-effort admission switch. Let admitted requests complete without rechecking service state or locking submission against disable. Remove the guard plumbing and strict ordering tests, and cover disable during Produce for all acknowledgement modes. Wait for table metadata before the concurrency test sends its first Produce request. Co-Authored-By: Codex <noreply@openai.com> AI-Model: gpt-6 AI-Contributed/Feature: 224/224 AI-Contributed/UT: 201/201
Restore Kafka service startup behavior and remove dynamic admission, connection draining, protocol shutdown hooks, and their tests and docs. Retain compression diagnostics, packaging, and distribution integration. Co-Authored-By: Codex <noreply@openai.com> AI-Model: gpt-6 AI-Contributed/Feature: 519/519 AI-Contributed/UT: 1562/1562
wuchong
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Closes #4864.
A collection of miscellaneous Kafka compatibility improvements.
Brief change log
Tests
mvn -o -B -pl fluss-kafka -am -DskipTests clean verify.API and Format
No configuration or storage format changes.
Documentation
No documentation changes required.