Repository navigation
Conversation
Register connections before starting an idempotent connect operation so immediate connection failures can remove the cached entry safely. Add regressions for immediate address resolution failure followed by reconnection and for concurrent requests sharing one connection. Co-Authored-By: Codex <noreply@openai.com> AI-Model: gpt-6 AI-Contributed/Feature: 64/64 AI-Contributed/UT: 114/114
Remove the test-only auto-connect constructor and start connections explicitly in existing tests. Reuse the single-loop client fixture, simplify the resolver stub, and trim redundant assertions and comments. Co-Authored-By: Codex <noreply@openai.com> AI-Model: gpt-6 AI-Contributed/Feature: 14/14 AI-Contributed/UT: 38/38
Queue connection eviction to avoid re-entering computeIfAbsent on an immediate connection failure. Keep conditional removal and the recovery regression, without changing ServerConnection initialization. Co-Authored-By: Codex <noreply@openai.com> AI-Model: gpt-6 AI-Contributed/Feature: 51/51 AI-Contributed/UT: 42/42
beryllw
changed the title
beryllw
marked this pull request as ready for review
October 27, 2026 05:57
Run the immediate DNS failure regression with one and four network threads. Keep connection establishment on the caller's event loop and wait for asynchronous cleanup before verifying recovery with the same client. Co-Authored-By: Codex <noreply@openai.com> AI-Model: gpt-6 AI-Contributed/Feature: 0/0 AI-Contributed/UT: 18/18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Closes #4904.
An immediate connection failure on a Netty event loop can invoke the removal callback inside
connections.computeIfAbsent(). The recursive removal fails, leaving a disconnected connection cached and preventing subsequent requests from reconnecting.Brief change log
Tests
test: all 14 tests inNettyClientTestandServerConnectionTestpassed, with one endpoint test rerun after a local port conflict. Formatting, Checkstyle and license checks passed.API and Format
No public API, RPC protocol or storage format changes.
Documentation
Not required.
Generative AI disclosure: