Repository navigation
Conversation
|
Run Gluten Clickhouse CI on x86 |
Add a shared build identity and publisher for Velox at /opt/velox. Pin the base and Velox commit, preserve dependency paths, and require a measured Gluten-only smoke build before publishing. Leave CI consumers unchanged for a follow-up. Generated-by: Codex GPT-6
The vcpkg-almalinux-8-gcc13 base image now runs dev/docker/install-ci-tools.sh (apache#13422), so changes to it must change the Velox image key and trigger the image check on pull requests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…Hub slots CI can't delete Docker Hub tags, so a tag per Velox key would grow without bound. Publish to velox-static-slot-0..7 instead, replacing the least recently published slot. Each image records its key and publish order in labels, and an existing key is reused. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
FelixYBW
force-pushed
the
ci/velox-static-image
branch
from
October 31, 2026 03:00
2c9e8ba to
fe7b14c
Compare
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
FelixYBW
force-pushed
the
ci/velox-static-image
branch
from
October 31, 2026 20:19
278e649 to
fe7b14c
Compare
|
Run Gluten Clickhouse CI on x86 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Part of #12288. Implements the publishing/key stage of the prebuilt Velox proposal, starting with the amd64 AlmaLinux 8/GCC 13 static variant. Native CI consumers remain unchanged; switching them to the image (the slot holding their key, else
velox-static-latest, which only needs an incremental Velox rebuild) is a follow-up after the image is measured and published./opt/velox. Build flags come directly from the existing x86 static CI script. Preserve the full Velox build tree and vcpkg dependencies at/opt/gluten/dev/vcpkg, since generated CMake files contain absolute paths.dev/docker/install-ci-tools.sh(now run by the base image), base image digest, and build variant/environment. Generated build outputs do not affect it. Fetch the resolved commit explicitly and verify the key before building.apache/gluten:velox-static-slot-0to-7, plusvelox-static-latestandvelox-static-almalinux-8-gcc13aliases. CI can't delete Docker Hub tags, so a tag per key would grow without bound (~0.6 key changes/day plus weekly base refreshes); a new key instead overwrites the least recently published slot. Each image records its key and publish order in theorg.apache.gluten.velox-keyandorg.apache.gluten.velox-sequencelabels, read from the manifest without pulling. An existing key is reused without rebuilding. The key and input metadata are also stored in/opt/velox/.velox-keyand.velox-build.json.docker_image.ymlalso calls it after the refreshed AlmaLinux base is published, including weekly refreshes. Onlyapache/glutenonmaincan publish, using the existing Docker Hub secrets; PRs run inexpensive key tests only.build_gluten_cppsmoke build withNUM_THREADS=2. Publish only after that build succeeds.How was this patch tested?
velox_image.ymlhas only been checked for valid YAML. The slot step'sdocker buildx imagetools inspectcall is unit-tested with mocked output and first runs for real on the first publish.git diff --checkpassed.dft-2026_10_23to0a477fa804b9424c8ce251bd8b1f60b1bdafd11cand hashed 129 tracked inputs.Draft: Docker image build and performance measurements are pending. This Windows workspace has neither Docker nor WSL, so no image-size, runner-disk, or Gluten-only timing claim is made. The publisher enforces the smoke build before publication, and the documented commands allow those measurements on an amd64 Linux Docker host. Keep this draft until those results are available; existing native CI has not been switched to consume the image.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Codex GPT-6, Claude claude-opus-5-5