feat: add SQL catalog#693
Open
zhjwpku wants to merge 2 commits into
Open
Conversation
Add a relational database backed SqlCatalog with a CatalogStore abstraction, built-in sqlpp23 stores for SQLite, PostgreSQL, and MySQL, and Java-compatible catalog tables.
wgtmac
reviewed
Jun 4, 2026
| shell: pwsh | ||
| run: | | ||
| vcpkg install zlib:x64-windows nlohmann-json:x64-windows nanoarrow:x64-windows roaring:x64-windows cpr:x64-windows | ||
| vcpkg install zlib:x64-windows nlohmann-json:x64-windows nanoarrow:x64-windows roaring:x64-windows cpr:x64-windows sqlite3:x64-windows |
Member
There was a problem hiding this comment.
Is it better to add a dedicated ci workflow for the sql catalog? We can trigger it only when files related to sql catalog have been changed to reduce resource usage.
| option(ICEBERG_BUILD_REST "Build rest catalog client" ON) | ||
| option(ICEBERG_BUILD_REST_INTEGRATION_TESTS "Build rest catalog integration tests" OFF) | ||
| option(ICEBERG_BUILD_HIVE "Build hive (HMS) catalog client" OFF) | ||
| option(ICEBERG_BUILD_SQL_CATALOG "Build SQL catalog client" ON) |
Member
There was a problem hiding this comment.
Should we make it off by default? This follows the pattern used by rest catalog library.
| ~ under the License. | ||
| --> | ||
|
|
||
| # SQL Catalog |
Member
There was a problem hiding this comment.
Perhaps it is good to add to the iceberg-cpp site as well.
| const TableIdentifier& identifier, | ||
| const std::string& metadata_file_location) override; | ||
|
|
||
| #ifdef BUILD_SQLITE3_CONNECTOR |
Member
There was a problem hiding this comment.
Would it be good to always make these functions visible to users? We can check BUILD_SQLITE3_CONNECTOR and other macros in the sql_catalog.cc file and return NotSupported if not built.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a relational database backed SqlCatalog with a CatalogStore abstraction, built-in sqlpp23 stores for SQLite, PostgreSQL, and MySQL, and Java-compatible catalog tables.