Repository navigation
Conversation
Use the shared property derive for REST catalog settings while retaining server merge precedence, injected clients, and secret redaction. Tracks [apache#3100](apache#3100). Generated-by: Codex
blackmwk
force-pushed
the
ir-3100-rest-properties
branch
from
September 4, 2026 03:23
f9fbc2d to
b08836c
Compare
Contributor
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
Contributor
|
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
Resolve REST catalog conflicts while preserving property derivation, page-size precedence, table caching, and contextual authentication.
Replace RestCatalogConfig with derived RestCatalogProperties for catalog, authentication, headers, pagination, and cache settings. Keep raw properties and runtime injections outside the typed projection, and preserve validation after server overrides for pagination and caching.
blackmwk
commented
Oct 27, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Replace
RestCatalogConfigwith aProperties-derivedRestCatalogPropertiescovering catalog locations and prefix, authentication and OAuth settings, typed headers, header redaction, pagination, and cache capacity/expiry. Keep raw property maps and injected runtime objects outside the typed configuration.Preserve server-default < client < server-override precedence, complete property forwarding to auth/FileIO/KMS, and secret redaction. Page-size and cache settings are validated after the server handshake so overrides can replace invalid lower-priority values.
Are these changes tested?
cargo test -p iceberg-catalog-rest --lib --all-features --locked— 134 passed.cargo clippy -p iceberg-catalog-rest --all-targets --all-features --locked -- -D warningscargo test -p iceberg-catalog-rest --doc --all-features --locked— 2 passed, 3 ignored.make generate-public-api— all workspace snapshots unchanged.cargo fmt --all -- --checkandgit diff --checkAI Disclosure
Developed with assistance from OpenAI Codex. Review should focus on deferred page-size/cache validation, injected auth-manager precedence, and complete raw-property forwarding while keeping secrets out of debug output.