Repository navigation
Conversation
Discard deleted manifest entries before copying their metadata or dispatching scan work. Live entries still widen before partition pruning and delete matching, consistent with the spec and Java's live-entry scan. Share the promotion fixtures' old-schema data manifest and source-drop setup while preserving their schema, format, and sequence-number cases. Follow-up to apache#3483.
mbutrovich
self-requested a review
October 23, 2026 15:28
JeonDaehong
approved these changes
Oct 25, 2026
JeonDaehong
left a comment
JeonDaehong
left a comment
Contributor
There was a problem hiding this comment.
Looks right to me. fetch_manifest_and_stream_manifest_entries is the only place that builds a ManifestEntryContext (context.rs:159), so dropping the checks in process_data_manifest_entry / process_delete_manifest_entry loses nothing. Deleted entries also no longer go through promoted_partition, which matches Java planning over live entries only. The red security_audit is RUSTSEC-2026-0385 (#3517), not this change. LGTM.
laskoviymishka
approved these changes
Oct 25, 2026
laskoviymishka
left a comment
laskoviymishka
left a comment
Contributor
There was a problem hiding this comment.
Nice and clean! Thanks!
Contributor
|
@anoopj -- will wait for @mbutrovich before merge. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are included in this PR?
Discard deleted manifest entries before copying their metadata or dispatching scan work. Live entries still widen before partition pruning and delete matching, consistent with the spec and Java's live-entry scan.
Share the promotion fixtures' old-schema data manifest and source-drop setup while preserving their schema, format, and sequence-number cases.
Follow-up to #3483.
Are these changes tested?
Covered by existing tests.