Skip to content

chore(release): check crate LICENSE/NOTICE files in verify_rc.sh - #3553

Merged
kevinjqliu merged 1 commit into
apache:mainfrom
ninglinLiu:feat/verify-rc-crate-licenses
Oct 27, 2026
Merged

kevinjqliu merged 1 commit into
apache:mainfrom
ninglinLiu:feat/verify-rc-crate-licenses

Conversation

@ninglinLiu

@ninglinLiu ninglinLiu commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

What changes are included in this PR?

RC voters currently only get the "every publishable crate packages the root LICENSE and NOTICE" guarantee from CI. This adds it to dev/release/verify_rc.sh, run against the extracted source archive:

  • New --check_crate_licenses <0|1> option (also accepts --check-crate-licenses), default 1, validated like the other boolean options.
  • check_crate_licenses requires cargo and python3 and runs python3 <archive>/dev/release/licenses.py crates check. licenses.py resolves REPO_ROOT from its own path, so it checks the extracted archive rather than the local checkout.
  • Usage text and dev/release/README.md document the option and default; the "skip everything" example passes --check_crate_licenses 0.

Are these changes tested?

Ran bash -n dev/release/verify_rc.sh, checked --help output and that invalid values (e.g. --check_crate_licenses 2) are rejected, and ran python3 dev/release/licenses.py crates check from a git archive extraction of this branch (the same invocation check_crate_licenses uses), which passes.

This PR was prepared with AI assistance and reviewed/tested by the author.

@dannycjones dannycjones left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinjqliu kevinjqliu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

thanks for following up with the fix 😄

Comment thread dev/release/verify_rc.sh
VERIFY_GIT_TAG="1"
GIT_REPO_URL="https://github.com/apache/iceberg-rust.git"
CHECK_HEADERS="1"
CHECK_CRATE_LICENSES="1"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kevinjqliu
kevinjqliu added this pull request to the merge queue Oct 27, 2026
Merged via the queue into apache:main with commit 18d8ed2 Oct 27, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants