Repository navigation
chore(release): check crate LICENSE/NOTICE files in verify_rc.sh - #3553
Merged
Merged
Conversation
kevinjqliu
approved these changes
Oct 27, 2026
kevinjqliu
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
thanks for following up with the fix 😄
| VERIFY_GIT_TAG="1" | ||
| GIT_REPO_URL="https://github.com/apache/iceberg-rust.git" | ||
| CHECK_HEADERS="1" | ||
| CHECK_CRATE_LICENSES="1" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
licenses.py crates checkinverify_rc.shbehind a--check_crate_licensestoggle).What changes are included in this PR?
RC voters currently only get the "every publishable crate packages the root
LICENSEandNOTICE" guarantee from CI. This adds it todev/release/verify_rc.sh, run against the extracted source archive:--check_crate_licenses <0|1>option (also accepts--check-crate-licenses), default1, validated like the other boolean options.check_crate_licensesrequirescargoandpython3and runspython3 <archive>/dev/release/licenses.py crates check.licenses.pyresolvesREPO_ROOTfrom its own path, so it checks the extracted archive rather than the local checkout.dev/release/README.mddocument the option and default; the "skip everything" example passes--check_crate_licenses 0.Are these changes tested?
Ran
bash -n dev/release/verify_rc.sh, checked--helpoutput and that invalid values (e.g.--check_crate_licenses 2) are rejected, and ranpython3 dev/release/licenses.py crates checkfrom agit archiveextraction of this branch (the same invocationcheck_crate_licensesuses), which passes.This PR was prepared with AI assistance and reviewed/tested by the author.