IGNITE-28706 Fix TxWithExceptionalInterceptorTest.testTxWithExceptionInterceptor fails#13162
Open
zstan wants to merge 1 commit into
Open
IGNITE-28706 Fix TxWithExceptionalInterceptorTest.testTxWithExceptionInterceptor fails#13162zstan wants to merge 1 commit into
zstan wants to merge 1 commit into
Conversation
Contributor
Author
|
After fix: "Run until failure" is ok |
…Interceptor fails
|
| sqlVal = getSqlResultByKey(node, PROC_CACHE_NAME, primaryKey, false); | ||
| } | ||
| catch (IgniteSQLException ex) { | ||
| assertTrue(X.hasCause(ex, ClusterTopologyException.class)); |
Contributor
There was a problem hiding this comment.
-
Block under condition
txCoord == TxCoordNodeRole.PRIMARYusesgetSqlResultByKeymethod too, but not covered by the same check. Why? -
There is a line in this method:
Integer primaryKeyCommon = primaryKeyCoordAware(PROC_CACHE_NAME);
Here PROC_CACHE_NAME is used, but not COMMON_CACHE_NAME. Is it intentional?
- Several code style violations in this method (comment is not started with uppercase, and not ended with the point. Let's fix it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.