Repository navigation
KAFKA-21418: Cleanup DelegationTokenCache and CredentialCache - #24093
Open
FrankYang0529 wants to merge 1 commit into
Open
FrankYang0529 wants to merge 1 commit into
FrankYang0529 wants to merge 1 commit into
Conversation
Signed-off-by: PoAn Yang <payang@apache.org>
FrankYang0529
force-pushed
the
KAFKA-21418
branch
from
November 3, 2026 10:24
75a607f to
0fe0389
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DelegationTokenCachekept a tokenId -> hmac map only so thatremoveToken()could find the hmac entry to drop. The token cache nowstores the
DelegationTokenitself, which already carries the hmac, sothat map is gone.
addToken()now takes aDelegationTokenand keepsthe hmac -> tokenId map in step with the token cache. The unused
tokenIdForHmac()is removed as well.CredentialCacheis only ever used withScramCredential, so thegeneric type parameter and the credential class check are removed.
ScramCredentialUtilswas down to a single helper,createCache(). Itis replaced by a
CredentialCacheconstructor that creates a cache foreach SCRAM mechanism in the given collection, and
ScramCredentialUtilsis removed.