Repository navigation
MINOR: Always compare the password in PlainServerCallbackHandler - #24094
Open
aashish-confluent wants to merge 2 commits into
Open
aashish-confluent wants to merge 2 commits into
aashish-confluent wants to merge 2 commits into
Conversation
PlainServerCallbackHandler returned early for an unknown user without comparing the password, so authentication took less time for unknown users than for known ones. Compare the supplied password against a dummy value in that case, so the comparison always runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compare the supplied password against a dummy value when the user is unknown.
Added a unit test in PlainSaslServerTest.