Spring boot4#460
Open
rgoers wants to merge 6 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR restructures dependency/version management by introducing a new third-party BOM module, updates parent/bom version wiring, and adds a new RoutableProxyChannelSelector implementation (plus related config enums and tests). It also introduces SpotBugs suppression annotations in several core classes and minor API/config updates.
Changes:
- Add
flume-third-partymodule to centralize third-party dependency versions/BOM imports and wire it intoflume-parent. - Add
RoutableProxyChannelSelectorplus enum/config support and a new unit test. - Adjust various modules for SpotBugs annotation usage and dependency management cleanup.
Reviewed changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| pom.xml | Adds the new flume-third-party module to the reactor build. |
| flume-third-party/pom.xml | New BOM-style module defining third-party versions and managed dependencies. |
| flume-parent/pom.xml | Imports the new third-party BOM and shifts version properties/dependencyManagement accordingly. |
| flume-ng-node/pom.xml | Removes commented dependencies and relies on managed versions (drops explicit jsr305 version). |
| flume-ng-core/src/test/java/org/apache/flume/channel/TestRoutableProxyChannelSelector.java | Adds tests for the new routable proxy selector. |
| flume-ng-core/src/main/java/org/apache/flume/source/ExecSource.java | Adds SpotBugs suppression annotation. |
| flume-ng-core/src/main/java/org/apache/flume/sink/LoadBalancingSinkProcessor.java | Adds SpotBugs suppression annotation. |
| flume-ng-core/src/main/java/org/apache/flume/sink/FailoverSinkProcessor.java | Adds SpotBugs suppression annotation. |
| flume-ng-core/src/main/java/org/apache/flume/sink/AbstractSinkProcessor.java | Adds SpotBugs suppression annotation. |
| flume-ng-core/src/main/java/org/apache/flume/sink/AbstractSingleSinkProcessor.java | Adds SpotBugs suppression annotation. |
| flume-ng-core/src/main/java/org/apache/flume/lifecycle/LifecycleSupervisor.java | Adds SpotBugs suppression annotation. |
| flume-ng-core/src/main/java/org/apache/flume/channel/RoutableProxyChannelSelector.java | Introduces the new routable proxy selector implementation. |
| flume-ng-core/src/main/java/org/apache/flume/channel/MultiplexingChannelSelector.java | Adds SpotBugs suppression annotation. |
| flume-ng-core/src/main/java/org/apache/flume/channel/LoadBalancingChannelSelector.java | Adds SpotBugs suppression annotation. |
| flume-ng-core/src/main/java/org/apache/flume/channel/ChannelProcessor.java | Adds an overload constructor to allow supplying interceptors programmatically. |
| flume-ng-core/pom.xml | Adds provided dependency for spotbugs-annotations and relies on managed versions for jsr305. |
| flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java | Adds @SuppressFBWarnings but via a Log4j internal annotation import. |
| flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelType.java | Adds a KAFKA channel type and an unused helper method. |
| flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelSelectorType.java | Adds ROUTABLE_PROXY selector type mapping for the new selector. |
| flume-ng-channels/flume-file-channel/pom.xml | Relies on managed version for jsr305 (drops explicit version). |
| flume-bom/pom.xml | Updates Spring Boot BOM property versioning and introduces flume-rpc.version usage for RPC artifacts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+104
to
+110
| private ChannelSelector getSelector(Event event) { | ||
| ChannelSelector channelSelector = selectorMap.get(event.getHeaders().get(headerName)); | ||
| if (channelSelector == null) { | ||
| channelSelector = defaultSelector; | ||
| } | ||
| return channelSelector; | ||
| } |
SpotBugs honors any annotation whose simple name is SuppressFBWarnings, so a tiny internal annotation lets us avoid shipping a build dependency on the LGPL-licensed spotbugs-annotations artifact. Assisted-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.