Repository navigation
docs(pr-management): export the PR head for adversarial reviewers - #1986
Merged
Merged
Conversation
Reviewers given an empty --repo-dir see only the diff and reply without findings, so the code-review skill now exports the PR's head instead. The export excludes the vetted-ops policy path, which the secure setup denies writing anywhere, so the rule stays in place and the export completes. The skill also says the exported tree now reaches the reviewers' providers. Generated-by: Claude Opus 5
11 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
code-reviewskill now gives adversarial reviewers an export of the PR's head as--repo-dir, instead of an empty directory. With an empty directory they see only the diff, title and body, and reply without findings..apache-magpie-overrides/tools/vetted-ops. The secure setup denies writes to that path wherever it appears, so a fullgit archive | tar -xstops partway through. The deny rule stays as it is.Type of change
.claude/skills/<name>/) — eval fixtures updated belowtools/<system>/*.md)tools/*/withpyproject.toml)docs/,README.md,CONTRIBUTING.md)projects/_template/)prek, workflows, validators)Test plan
prek run --fileswithworkspace-pytestskipped reports no failures.prek run --all-fileswas not run.pr-management-code-review— not run. No fixtures changed.git archiveexport against a real PR head under the sandbox.tarexited 0 and the policy path is absent.Notes for reviewers
git archivehonoursexport-ignore, so those paths are missing from the export too. The skill says so.<upstream>" rule covers this.Gen-AI disclosure
Drafted with Claude Code (Claude Opus 5), and reviewed by the maintainer opening this PR.
🤖 Generated with Claude Code