Repository navigation
fix(pr-management): keep a finding's suggestion in the review - #1987
Merged
Merged
Conversation
code-review render posted a finding's explanation or its suggestion, so a finding carrying both lost the fix it recommended. The review body and inline comments now carry both. Generated-by: Claude Opus 5
potiuk
enabled auto-merge (squash)
November 4, 2026 13:16
github-actions
Bot
added
family:tools
14 of 20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
code-review renderbuilt a finding's text from its explanation or its suggestion, never both. A finding carrying both lost the recommended fix from the review body and from its inline comment._textnow joins the two, and still falls back to the rule when a finding has neither.Found during a review on 2026-11-04, when the fix text was missing from a rendered draft. An earlier round needed a follow-up comment on several PRs for the same reason.
Type of change
.claude/skills/<name>/) — eval fixtures updated belowtools/<system>/*.md)tools/*/withpyproject.toml)docs/,README.md,CONTRIBUTING.md)projects/_template/)prek, workflows, validators)Test plan
prek run --all-files --skip workspace-pytestpassesprek run workspace-pytest --from-ref <upstream main> --to-ref HEADpassesGen-AI disclosure
Drafted with Claude Code (Claude Opus 5), and reviewed by the maintainer opening this PR.
🤖 Generated with Claude Code