Repository navigation
fix(pr-management): make no committer claim without a roster - #1988
Merged
Merged
Conversation
code-review reviewers labelled every non-owner "not a committer" even when no roster had been loaded, so a PMC member could be described as a non-committer in a posted review. With no roster the role is now unknown and the reason does not mention it. The command also asks for the configured committers team through needs, which nothing requested before. Generated-by: Claude Opus 5
potiuk
enabled auto-merge (squash)
November 4, 2026 13:17
github-actions
Bot
added
family:tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
code-review reviewerslabelled every non-owner "frequent contributor, not a committer", even with no roster loaded. Nothing writescommitters.txt, and the configured team was never requested, so the roster was always empty. A PMC member was labelled that way in a draft review on 2026-11-04.committerisnullin the output. With a roster, the wording is unchanged.reviewersnow asks for thecommitters_teamroster throughneeds.Notes for reviewers
committers_team, where candidates simply get no role. This repository does not set it today.committers.txtis still read and still has no writer. I left that alone as out of scope.Type of change
.claude/skills/<name>/) — eval fixtures updated belowtools/<system>/*.md)tools/*/withpyproject.toml)docs/,README.md,CONTRIBUTING.md)projects/_template/)prek, workflows, validators)Test plan
prek run --all-files --skip workspace-pytestpassesprek run workspace-pytest --from-ref <upstream main> --to-ref HEADpassesGen-AI disclosure
Drafted with Claude Code (Claude Opus 5), and reviewed by the maintainer opening this PR.
🤖 Generated with Claude Code