Skip to content

fix(test): publish shell owner readiness markers atomically #6135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Astro-Han merged 1 commit into from
Oct 19, 2026
Merged

fix(test): publish shell owner readiness markers atomically #6135

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/runtime/src/__tests__/shell-owner-death.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,11 @@ for (const mode of ['bounded', 'pipes', 'wrapped']) {
const marker = join(directory, 'started.json');
const late = join(directory, 'late.txt');
const script = join(directory, 'writer.cjs');
// Publish only complete JSON: creating the final file before writing it
// lets the owner's readiness poll observe an empty marker.
await writeFile(
script,
`const fs=require('node:fs');\nprocess.on('SIGTERM',()=>{});\nfs.writeFileSync(${JSON.stringify(marker)},JSON.stringify({pid:process.pid,ppid:process.ppid}));\nsetTimeout(()=>fs.writeFileSync(${JSON.stringify(late)},'late'),1500);\nsetInterval(()=>{},1000);`,
`const fs=require('node:fs');\nprocess.on('SIGTERM',()=>{});\nfs.writeFileSync(${JSON.stringify(`${marker}.tmp`)},JSON.stringify({pid:process.pid,ppid:process.ppid}));\nfs.renameSync(${JSON.stringify(`${marker}.tmp`)},${JSON.stringify(marker)});\nsetTimeout(()=>fs.writeFileSync(${JSON.stringify(late)},'late'),1500);\nsetInterval(()=>{},1000);`,
);
const owner = fork(
new URL('./fixtures/shell-owner.js', import.meta.url),
Expand Down Expand Up @@ -107,7 +109,7 @@ test('owner SIGKILL also terminates a descendant that left the command group wit
const marker = join(directory, 'escaped.json');
const late = join(directory, 'late.txt');
const script = join(directory, 'escaper.cjs');
const escapee = `const fs=require('node:fs');process.on('SIGTERM',()=>{});fs.writeFileSync(${JSON.stringify(marker)},JSON.stringify({pid:process.pid,pgid:process.pid}));setTimeout(()=>fs.writeFileSync(${JSON.stringify(late)},'late'),1500);setInterval(()=>{},1000);`;
const escapee = `const fs=require('node:fs');process.on('SIGTERM',()=>{});fs.writeFileSync(${JSON.stringify(`${marker}.tmp`)},JSON.stringify({pid:process.pid,pgid:process.pid}));fs.renameSync(${JSON.stringify(`${marker}.tmp`)},${JSON.stringify(marker)});setTimeout(()=>fs.writeFileSync(${JSON.stringify(late)},'late'),1500);setInterval(()=>{},1000);`;
// The command stays alive while its child leads a new session, outside the
// supervisor's process group but still inside its process tree.
await writeFile(
Expand Down