Repository navigation
refactor(desktop): move session shell rules into feature owners - #6137
Closed
YayoiNanoka wants to merge 1 commit into
Closed
YayoiNanoka wants to merge 1 commit into
YayoiNanoka wants to merge 1 commit into
Conversation
Generated-by: OpenAI Codex
4 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The desktop app shell directly contains session mode commands, optimistic settings presentation, composer surface ownership checks, and parent-session breadcrumb assembly. Keeping these responsibilities inline makes the multi-window change in #6093 harder to review independently.
This refactor moves those existing rules into their owning conversation, session settings, and session navigation features. The shell continues to supply the same selection refs and commands. The navigation regression test now exercises the breadcrumb action, and the renderer architecture ledger is regenerated.
User-visible behavior stays unchanged. This provides a small, independently reviewable prerequisite for simplifying #6093; it introduces no window coordination or new persistence.
Validation: full build and workspace typecheck; all 3,847 desktop tests; strict renderer architecture check against
face9409; app-shell hook check; lint, formatting, and Astryx surface inventory.点击展开中文
桌面 app shell 直接包含 session 模式命令、乐观设置展示、输入框所属页面判断以及父 session 面包屑组装。这些职责放在 shell 内,使 #6093 的多窗口修改难以独立审查。
本次重构将已有规则移到对应的对话、session 设置和 session 导航模块。Shell 仍然传入相同的选择引用与命令。导航回归测试改为验证面包屑动作,并重新生成 renderer 架构清单。
用户可见行为保持不变。该 PR 为精简 #6093 提供一个小型、可独立审查的前置重构,不引入窗口协调或新的持久化。
验证:完整构建、全工作区类型检查、3,847 项桌面测试、以
face9409为基线的严格架构检查,以及 app-shell hook、lint、格式和 Astryx 清单检查。