Repository navigation
fix(ci): restore rust-preview recovery and macOS checks - #6779
Merged
Merged
Conversation
Keep one-shot DTOs and preparation states inline instead of adding allocations only to satisfy large_enum_variant. Share immutable reader access across source slices to avoid cloning scope strings. Generated-by: Maka
Retain unresolved Goal iterations, preserve original safe-prefix proofs, and interrupt active model requests for steering. Rebuild bound Goal and bot tool visibility consistently and prepare continuations from effective tool availability. Update recovery assertions for failed runs and referenced receipts while preserving identity, cleanup and exactly-once effects. Cover streaming cancellation before headers and after accepted output with real Host fixtures. Generated-by: Maka
Assert GoalStatus is visible and its actual tool results finish the Goal. Open New Goal from the existing Goal dialog and enter a cancellable objective instead of treating a disabled empty form as pressable. Generated-by: Maka
Persist StopRequested and interactive queue retractions in one Root transaction. Keep exact historical runs stoppable without clearing the current queue, preserve Goal and Schedule submissions, and leave messages admitted after a repeated or terminal Stop untouched. Cover rollback, source isolation, replay, independent reopen and ledger rebuild in the state test, plus public cancelled delivery and physical cleanup in the existing Host reopen test. Generated-by: Maka
Use find directly and combine the existing successful-cleanup guards without changing assertions or teardown order. Generated-by: Maka
Use the upstream Bot visibility restoration and distinguish explicitly cancelled model work from interrupted empty streams so frozen retry evidence remains available. Generated-by: Maka
Generated-by: Maka
Preserve empty-stream retries while Stop, finish and steering retain their existing recovery fences. Align driver fixtures with completion placement and claim ownership. Generated-by: Maka
Generated-by: Maka
Cancelled secondary autofocus must not fence the offscreen main editor. Establish the native-window baseline after AppKit text input initializes, then verify desktop requests preserve window identity, visibility and paste. Generated-by: Maka
MicroGery
added a commit
to MicroGery/maka-agent
that referenced
this pull request
Nov 11, 2026
Retry pending work after Goal or Session admission locks are released without blocking unrelated Sessions. Add a lock-contention regression and cumulative Goal-budget diagnostics. Separate Windows child readiness from the pipe-drain deadline and make the TUI scrolling fixture exactly one row tall. Preserve the recovery and macOS fixes already merged in apache#6779. Generated-by: Codex
4 of 7 tasks
4 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Repair the failing
rust-previewrecovery and desktop checks without relaxing replay fences or skipping tests.GoalStatusresults and the New Goal dialog.ToolResultReadershares immutable access on its real clone path; no end-to-end performance claim is made.The durable safe-prefix SQL fence is unchanged. No retry fallback, timeout increase, test deletion, new skip, CI routing change, or public schema migration is introduced.
Verification
Local Apple Silicon macOS; frozen base
5119f9d6c, final repair commit64cbd1243. Checks use the maintainedscripts/ci.mjsentry points. Required local tools included ripgrep, cargo-nextest and cargo-deny; the missing ripgrep dependency was installed rather than bypassing grep-parity tests.node scripts/ci.mjs check formatcargo clippy --locked --workspace --all-targets --features maka-cli/desktop-tests -- -D clippy::allnode scripts/ci.mjs run rootnode scripts/ci.mjs run macos-agent-executionnode scripts/ci.mjs run nshnode scripts/ci.mjs run macos-surfacenode scripts/ci.mjs run desktopnode scripts/ci.mjs run pixelsrootEarlier in the same investigation, the maintained
tooling,native,macos-host,macos-desktop,macos-nsh,contracts,product,bridge, andnative-buildsuites also exited 0. These were not all repeated after the final localized repairs. The original full run was red; the table above records completed repairs and reruns, not a claim that the first run passed.Behavior evidence from the final desktop run:
The initial desktop Goal timeout did not include a caller backtrace. Both subsequent full desktop executions passed, but that does not independently establish the cause of the original timeout.
Linux/Windows execution and hosted GitHub Actions were not run locally. Remote CI must still validate the PR merge result against the current branch.
AI use
Tool(s) and scope: Maka investigated failures, authored production/test changes, ran local checks, and performed a bounded independent-session review of the final four repairs. All material commits carry
Generated-by: Maka; retain that trailer when squashing. AI review is not independent human approval.Checklist
Does this PR entail a change in behavior?