Skip to content

make withLevel package private #1104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pjfanning wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −9
Open

make withLevel package private #1104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a65374
make withLevel package private
pjfanning Jun 27, 2026
8c6a5b8
comment
pjfanning Jun 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions http/src/main/scala/org/apache/pekko/http/scaladsl/coding/Deflate.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import pekko.annotation.InternalApi
import pekko.http.scaladsl.model._
import pekko.http.scaladsl.model.headers.HttpEncodings

@InternalApi
@InternalApi // used by javadsl.coding.Coder
@deprecated("Actual implementation of Deflate is internal API, use Coders.Deflate instead", since = "Akka HTTP 10.2.0")
class Deflate private[http] (compressionLevel: Int, val messageFilter: HttpMessage => Boolean) extends Coder
with StreamDecoder {
Expand All @@ -30,9 +30,9 @@ class Deflate private[http] (compressionLevel: Int, val messageFilter: HttpMessa
private[http] def newCompressor = new DeflateCompressor(compressionLevel)
def newDecompressorStage(maxBytesPerChunk: Int) = () => new DeflateDecompressor(maxBytesPerChunk)

@deprecated("Use Coders.Deflate(compressionLevel = ...) instead", since = "Akka HTTP 10.2.0")
def withLevel(level: Int): Deflate = new Deflate(level, messageFilter)
@InternalApi // used by javadsl.coding.Coder
private[http] def withLevel(level: Int): Deflate = new Deflate(level, messageFilter)
}
@InternalApi
@InternalApi // used by javadsl.coding.Coder
@deprecated("Actual implementation of Deflate is internal API, use Coders.Deflate instead", since = "Akka HTTP 10.2.0")
object Deflate extends Deflate(Encoder.DefaultFilter)
8 changes: 4 additions & 4 deletions http/src/main/scala/org/apache/pekko/http/scaladsl/coding/Gzip.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import pekko.annotation.InternalApi
import pekko.http.scaladsl.model._
import pekko.http.scaladsl.model.headers.HttpEncodings

@InternalApi
@InternalApi // used by javadsl.coding.Coder
@deprecated("Actual implementation of Gzip is internal, use Coders.Gzip instead", since = "Akka HTTP 10.2.0")
class Gzip private[http] (compressionLevel: Int, val messageFilter: HttpMessage => Boolean) extends Coder
with StreamDecoder {
Expand All @@ -30,14 +30,14 @@ class Gzip private[http] (compressionLevel: Int, val messageFilter: HttpMessage
private[http] def newCompressor = new GzipCompressor(compressionLevel)
def newDecompressorStage(maxBytesPerChunk: Int) = () => new GzipDecompressor(maxBytesPerChunk)

@deprecated("Use Coders.Gzip(compressionLevel = ...) instead", since = "Akka HTTP 10.2.0")
def withLevel(level: Int): Gzip = new Gzip(level, messageFilter)
@InternalApi // used by javadsl.coding.Coder
private[http] def withLevel(level: Int): Gzip = new Gzip(level, messageFilter)
}

/**
* An encoder and decoder for the HTTP 'gzip' encoding.
*/
@InternalApi
@InternalApi // used by javadsl.coding.Coder
@deprecated("Actual implementation of Gzip is internal API, use Coders.Gzip instead", since = "Akka HTTP 10.2.0")
object Gzip extends Gzip(Encoder.DefaultFilter) {
def apply(messageFilter: HttpMessage => Boolean) = new Gzip(messageFilter)
Expand Down
2 changes: 1 addition & 1 deletion http/src/main/scala/org/apache/pekko/http/scaladsl/coding/NoCoding.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import pekko.util.ByteString
/**
* An encoder and decoder for the HTTP 'identity' encoding.
*/
@InternalApi
@InternalApi // used by javadsl.coding.Coder
@deprecated("Actual implementation of NoCoding is internal API, use Coders.NoCoding instead",
since = "Akka HTTP 10.2.0")
object NoCoding extends Coder with StreamDecoder {
Expand Down