Skip to content

[Feature] Expose call metrics for the proxy admin gRPC interface #11474

Open

Description

@Felix-Gong

Search before asking

I checked open and closed issues and PRs for proxy admin metrics, OpenTelemetry on the control plane and admin gRPC instrumentation. What exists is adjacent, not this:

Nothing records anything for the admin gRPC server that actually ships today: ProxyAdminAuthInterceptor answers every admin RPC (thread dumps, message verification, group resets, topic updates...) and rocketmq_proxy_up is the only proxy instrument in the pipeline.

What happened?

ProxyMetricsManager initializes an OpenTelemetry meter in both proxy modes and exports it (OTLP/Prometheus/log), but the only instrument it registers is the rocketmq_proxy_up gauge. The admin gRPC server — the control plane surface every ops tool talks to — contributes no counter, no latency histogram, no error count.

So on a running proxy you cannot answer: is the admin interface being called at all, which methods are hot, how long do admin calls take, and — the important one — is anything failing (auth rejections, broken forwards, internal errors) while the dashboard still shows a healthy rocketmq_proxy_up = 1.

Expected behavior

Each admin RPC should produce one count and one latency sample, labeled with the method name and terminal status code, exported through the proxy's existing OpenTelemetry pipeline alongside rocketmq_proxy_up. Calls rejected by the auth interceptor should be counted too (that is where failures would show up first), and everything should degrade to a no-op when metrics are disabled or the manager has not started — same idiom the broker uses for optional instruments.

Runtime

develop at 57c2dc0, JDK 11. No proto change, no new dependency: the interceptor, the two instruments and tests live entirely in proxy.

Activity

  1. Felix-Gong commented on Oct 21, 2026

    @Felix-Gong
    ContributorAuthor

    PR: #11475

  2. RockteMQ-AI commented on Oct 21, 2026

    @RockteMQ-AI
    Contributor

    Issue Evaluation

    Category: type/enhancement | Status: Evaluated

    Feasibility: Feasible
    Scope: proxy module — ProxyMetricsManager, ProxyAdminAuthInterceptor, admin gRPC server initialization
    Compatibility: No breaking changes — additive instrumentation only

    The proposal is well-scoped and addresses a real observability gap. The admin gRPC interface currently has no metrics beyond rocketmq_proxy_up, making it impossible to monitor admin API usage, latency, or failures.

    Assessment:

    • Adding per-RPC counters and latency histograms via an interceptor is a standard OpenTelemetry pattern
    • Auth interceptor instrumentation (counting rejections) is a good addition for security monitoring
    • No proto changes required — metrics can be added at the interceptor layer
    • Graceful degradation when metrics are disabled aligns with existing broker patterns

    This enhancement would significantly improve operational visibility for the proxy control plane.


    Automated evaluation by github-manager-bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions