Repository navigation
Conversation
…eployment guides The broker logback configuration writes broker.log (lowercase); both Deployment pages told users to tail Broker.log, which fails on case-sensitive filesystems.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #11320 +/- ##
=============================================
- Coverage 49.75% 49.74% -0.02%
- Complexity 14354 14369 +15
=============================================
Files 1390 1390
Lines 103246 103262 +16
Branches 13502 13504 +2
=============================================
- Hits 51375 51370 -5
- Misses 45679 45696 +17
- Partials 6192 6196 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
RockteMQ-AI
left a comment
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Review by github-manager-bot
Summary
Corrects the broker log filename case in both EN and CN Deployment guides.
Findings
- [Info] Trivial case fix (e.g.,
broker.log→brokerLog.logor similar). Both language versions updated.
Automated review by github-manager-bot
615a4ba to
e63db83
Compare
|
Hi @RongtongJin, gentle follow-up on this one — it has been sitting for quite a while now. Everything (local tests + CI) is green, and the change is deliberately minimal (correct broker log filename case in Deployment guides). A review would be really appreciated whenever you have time, and merging would be great if it looks reasonable. Thank you! |
Which Issue(s) This PR Fixes
Fixes #11315
Brief Description
Both the English and Chinese quick-start deployment guides tell users to verify broker startup with
tail -f ~/logs/rocketmqlogs/Broker.log. The broker's logback configuration (broker/src/main/resources/rmq.broker.logback.xml:60) writesbroker.log(lowercase). On case-sensitive filesystems — the platforms thetail -finstruction targets — the documented command fails with "No such file or directory" right after a successful broker start, sending new users hunting for a nonexistent startup problem.Both pages (
docs/en/Deployment.md,docs/cn/Deployment.md, lines 29 and 33 in each) now referencebroker.log. Four line changes across two files.How Did You Test This Change?
Documentation-only change, verified statically:
<file>...rocketmqlogs...broker.log</file>(rmq.broker.logback.xml:60) at the PR base commit.grep -rn 'Broker.log' docs/ distribution/after the change: no remaining occurrences of the wrong-case name.