Repository navigation
Conversation
…rWithNamespace Print SendResult.getSendStatus() instead of an unconditional 'send success', so FLUSH_DISK_TIMEOUT / FLUSH_SLAVE_TIMEOUT / SLAVE_NOT_AVAILABLE results are visible; also fix the misId typo.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #11343 +/- ##
=============================================
- Coverage 49.75% 49.69% -0.07%
- Complexity 14354 14355 +1
=============================================
Files 1390 1390
Lines 103246 103262 +16
Branches 13502 13504 +2
=============================================
- Hits 51375 51314 -61
- Misses 45679 45743 +64
- Partials 6192 6205 +13 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
RockteMQ-AI
left a comment
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Review by github-manager-bot
Summary
Fixes ProducerWithNamespace to report the real send status instead of a hardcoded value.
Findings
- [Info] Trivial one-line fix. Reporting the actual
SendResultstatus is the correct behavior.
Automated review by github-manager-bot
6217a4b to
d9efcb6
Compare
|
Hi @RongtongJin, gentle follow-up on this one — it has been sitting for quite a while now. Everything (local tests + CI) is green, and the change is deliberately minimal (report real send status in ProducerWithNamespace). A review would be really appreciated whenever you have time, and merging would be great if it looks reasonable. Thank you! |
Which Issue(s) This PR Fixes
Fixes #11329
Brief Description
ProducerWithNamespaceprintedsend successfor every send that returned without throwing, butDefaultMQProducer.sendcan return normally withFLUSH_DISK_TIMEOUT,FLUSH_SLAVE_TIMEOUTorSLAVE_NOT_AVAILABLE— exactly the degraded-persistence cases a learner should see. The output now printsresult.getSendStatus()instead of an unconditional success claim (and fixes themisIdtypo).How Did You Test This Change?
mvn -pl example -am -DskipTests compile(JDK 11, PR base commit) → BUILD SUCCESS with the change.SendResult.getSendStatus()is the standard accessor used by other examples (e.g.operation/Producer.javaprints the fullSendResult).