Repository navigation
Conversation
…nmessaging SimpleProducer The blocking producer.send() printed 'Send async message OK', the same line the real sendAsync() path prints; label it 'Send sync message OK'.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #11344 +/- ##
=============================================
- Coverage 49.68% 49.67% -0.01%
- Complexity 14331 14334 +3
=============================================
Files 1390 1390
Lines 103246 103246
Branches 13502 13502
=============================================
- Hits 51298 51290 -8
- Misses 45743 45754 +11
+ Partials 6205 6202 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Review by github-manager-bot
Summary
Fixes the sync send label in SimpleProducer example to correctly identify the send type.
Findings
- [Info] Trivial one-line fix. Correct label improves example clarity.
Automated review by github-manager-bot
|
Issue Evaluation Category: The example output mislabeling is valid. The blocking Root Cause: Copy-paste error in the example's println statement. The proposed one-line fix (changing the sync block's output to "Send sync message OK") correctly addresses the mislabeling. Automated evaluation by github-manager-bot |
a594a07 to
b2a850c
Compare
|
Sorry to bother you @RongtongJin — just nudging this PR since it hasn't had any feedback yet. Tests and CI are green on my end, and the fix (label the sync send as sync in openmessaging SimpleProducer) is ready to go. Could you help review it and, if it works for you, merge it? More than happy to address any comments. Thanks! |
Which Issue(s) This PR Fixes
Fixes #11332
Brief Description
The blocking
producer.send(message)call in the OpenMessagingSimpleProducerexample printedSend async message OK, the exact line the realsendAsync(...)listener path prints below it, so the demo's output cannot distinguish its synchronous send from its asynchronous one. The sync block now printsSend sync message OK(one-line change).How Did You Test This Change?
mvn -pl example -am -DskipTests compile(JDK 11, PR base commit) → BUILD SUCCESS with the change. Output-string change only; both labels verified against the example's actual control flow (blockingsendvssendAsynclistener).