Skip to content

[ISSUE #11332] fix(example): label the sync send as sync in openmessaging SimpleProducer - #11344

Open
chennaji9 wants to merge 1 commit into
apache:developfrom
chennaji9:cnj/example-om-sync-label
Open

chennaji9 wants to merge 1 commit into
apache:developfrom
chennaji9:cnj/example-om-sync-label

Conversation

@chennaji9

@chennaji9 chennaji9 commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Which Issue(s) This PR Fixes

Fixes #11332

Brief Description

The blocking producer.send(message) call in the OpenMessaging SimpleProducer example printed Send async message OK, the exact line the real sendAsync(...) listener path prints below it, so the demo's output cannot distinguish its synchronous send from its asynchronous one. The sync block now prints Send sync message OK (one-line change).

How Did You Test This Change?

mvn -pl example -am -DskipTests compile (JDK 11, PR base commit) → BUILD SUCCESS with the change. Output-string change only; both labels verified against the example's actual control flow (blocking send vs sendAsync listener).

…nmessaging SimpleProducer

The blocking producer.send() printed 'Send async message OK', the same
line the real sendAsync() path prints; label it 'Send sync message OK'.
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.67%. Comparing base (9ea2ccd) to head (a594a07).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop   #11344      +/-   ##
=============================================
- Coverage      49.68%   49.67%   -0.01%     
- Complexity     14331    14334       +3     
=============================================
  Files           1390     1390              
  Lines         103246   103246              
  Branches       13502    13502              
=============================================
- Hits           51298    51290       -8     
- Misses         45743    45754      +11     
+ Partials        6205     6202       -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RockteMQ-AI RockteMQ-AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review by github-manager-bot

Summary

Fixes the sync send label in SimpleProducer example to correctly identify the send type.

Findings

  • [Info] Trivial one-line fix. Correct label improves example clarity.

Automated review by github-manager-bot

@RockteMQ-AI

Copy link
Copy Markdown
Contributor

Issue Evaluation

Category: type/documentation | Status: Confirmed

The example output mislabeling is valid. The blocking producer.send(message) call prints "Send async message OK", which is identical to the sendAsync(...) listener output below it. This makes the example unable to distinguish synchronous from asynchronous sends.

Root Cause: Copy-paste error in the example's println statement.
Impact: Confusing for developers learning the OpenMessaging API; the example fails to demonstrate the difference between sync and async sends.
Severity: Low (example code only, no runtime impact)

The proposed one-line fix (changing the sync block's output to "Send sync message OK") correctly addresses the mislabeling.


Automated evaluation by github-manager-bot

@chennaji9
chennaji9 force-pushed the cnj/example-om-sync-label branch from a594a07 to b2a850c Compare October 18, 2026 08:10
@chennaji9

Copy link
Copy Markdown
Contributor Author

Sorry to bother you @RongtongJin — just nudging this PR since it hasn't had any feedback yet. Tests and CI are green on my end, and the fix (label the sync send as sync in openmessaging SimpleProducer) is ready to go. Could you help review it and, if it works for you, merge it? More than happy to address any comments. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] openmessaging SimpleProducer prints "Send async message OK" for its synchronous send

3 participants