[iloveeyjafjalla]

Which Issue(s) This PR Fixes

Fixes #11452

Problem

CheckpointFile.read reports a crc32 mismatch with a file=%s label but passes expectedCrc32 into it, so a corrupted checkpoint prints a checksum where the path belongs and never labels the expected value:

Entries crc32 not match, file=823222925, truth=823222924

The path being read is in scope (read(String filePath)) when the message is built.

Change

- "Entries crc32 not match, file=%s, truth=%s", expectedCrc32, truthCrc32);
+ "Entries crc32 not match, file=%s, expected=%s, truth=%s", filePath, expectedCrc32, truthCrc32);

Verification

CheckpointFileTest (the module that already owns the checkpoint test) gains testCrcMismatchReportsTheFileAndTheExpectedCrc, which corrupts the stored crc32 on both the checkpoint and its .bak fallback and asserts the message names the path and the expected checksum. Before the change:

java.lang.AssertionError: Entries crc32 not match, file=823222925, truth=823222924

After the change, with JDK 8 (mvn -B -ntp -pl remoting -am test -Dtest='CheckpointFileTest' -DfailIfNoTests=false -Djacoco.skip=true):

Tests run: 3, Failures: 0, Errors: 0, Skipped: 0
checkstyle:3.2.0:check: passed
spotbugs:4.8.6.8:check: BugInstance size is 0

The unit test is the verification for this one. The change was prepared with AI assistance and reviewed, tested and verified by me.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[RockteMQ-AI]

Review by github-manager-bot

Summary

This PR fixes a bug in CheckpointFile.read() where the CRC32 mismatch error message was printing the expected CRC value in the file=%s placeholder instead of the actual file path. The fix correctly passes filePath as the first format argument and adds a labeled expected=%s field for the expected CRC value. A new unit test validates the corrected error message.

Assessment: ✅ Looks Good

Correctness:

• The original bug is clear: String.format("file=%s, truth=%s", expectedCrc32, truthCrc32) was passing a long where a String (file path) was expected in the format string.
• The fix String.format("file=%s, expected=%s, truth=%s", filePath, expectedCrc32, truthCrc32) correctly resolves the argument order and adds proper labeling.
• The filePath parameter is available in scope (read(String filePath)), so no additional plumbing is needed.

Test Coverage:

• testCrcMismatchReportsTheFileAndTheExpectedCrc is well-structured: it corrupts both the primary and .bak checkpoint files, triggers the read, and asserts the error message contains the file path, expected CRC, and truth label.
• The test correctly uses System.lineSeparator() for cross-platform compatibility.

Minor Observations:

1. The error message format change is backward-incompatible for any tooling that parses this specific error string. However, since this is a diagnostic message for operators (not a machine-readable protocol), this is acceptable.
2. Consider whether filePath should be logged as an absolute path for easier debugging in production environments. Currently it depends on how the caller constructs the path.

Verdict

Clean, focused fix with proper test coverage. No blocking issues.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 49.72%. Comparing base (5d68880) to head (9cda1d6).

Files with missing lines	Patch %	Lines
...g/apache/rocketmq/common/utils/CheckpointFile.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##             develop   #11453      +/-   ##
=============================================
- Coverage      49.76%   49.72%   -0.05%     
+ Complexity     14377    14369       -8     
=============================================
  Files           1390     1390              
  Lines         103262   103262              
  Branches       13504    13504              
=============================================
- Hits           51392    51350      -42     
- Misses         45681    45713      +32     
- Partials        6189     6199      +10     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.