[hickey-ai]

Which Issue(s) This PR Fixes

Fixes #11460

Brief Description

Convert NumberFormatException from the two numeric checkpoint header fields to IOException with the file path and original cause. This lets the existing .bak recovery work for empty, truncated or malformed headers. The catch is limited to header parsing; serializer exceptions, empty-state behavior and normal primary precedence are not changed.

This is distinct from #11032, which handles persisting/reading empty checkpoint state.

How Did You Test This Change?

• The original implementation reproduced an unchecked NumberFormatException in the native common test. Surefire stopped after the first failure (2 reported: 1 error, 1 skipped); all six new methods were not claimed executed before the fix.
• Independent Java 8/Maven 3.6.3 run: mvn -B -pl remoting -am -Dtest=CheckpointFileHeaderTest,CheckpointFileTest -Dsurefire.failIfNoSpecifiedTests=false -DfailIfNoTests=false test.
• All 9 tests passed (6 new common header tests and 3 existing remoting checkpoint tests), 0 failures/errors/skips. Checkstyle and SpotBugs passed.
• Full published Git tree equals the tested local commit tree.

No live broker or HA failover test is claimed.

AI assistance: OpenAI Codex was used for investigation, implementation and tests; commits include tooling provenance.

[RockteMQ-AI]

LGTM. The fix improves error handling for corrupted checkpoint headers.

Summary

Wrapped Integer.parseInt() calls in CheckpointFile.read() to convert NumberFormatException to IOException with context.

Analysis

Checkpoint files have a two-line header (expected line count + CRC). If these lines are corrupted or truncated, the original code would throw a raw NumberFormatException without context. The fix converts this to an IOException with the file path included, which allows the checkpoint recovery mechanism to gracefully fall back to the backup file.

The test suite comprehensively covers malformed headers (truncated, non-numeric count, non-numeric CRC), fallback behavior, and valid primary precedence. All edge cases are well-covered.

---

Automated review by github-manager-bot