Skip to content

[ISSUE #11466] Extract group max length into a field in TopicValidator #11467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lizhimins merged 3 commits into from
Oct 27, 2026
+30 −2
Merged

[ISSUE #11466] Extract group max length into a field in TopicValidator #11467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a8c3ad
[ISSUE #11466] Make broker-side subscription group max length configu…
f1amingo Oct 20, 2026
d123846
Revert "[ISSUE #11466] Make broker-side subscription group max length…
f1amingo Oct 27, 2026
c659141
[ISSUE #11466] Extract group max length into a field in TopicValidator
f1amingo Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions common/src/main/java/org/apache/rocketmq/common/topic/TopicValidator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ public class TopicValidator {
private static final int GROUP_MAX_LENGTH = 120;
private static final int RETRY_OR_DLQ_TOPIC_MAX_LENGTH = 255;

private static volatile int groupMaxLength = GROUP_MAX_LENGTH;

private static final Set<String> SYSTEM_TOPIC_SET = new HashSet<>();

/**
Expand Down Expand Up @@ -139,6 +141,11 @@ public static ValidateResult validateTopic(String topic) {
return new ValidateResult(true, "");
}

public static void setGroupMaxLength(int maxLength) {
groupMaxLength = maxLength <= 0 ? GROUP_MAX_LENGTH
: Math.min(maxLength, RETRY_OR_DLQ_TOPIC_MAX_LENGTH);
}

public static ValidateResult validateGroup(String group) {

if (UtilAll.isBlank(group)) {
Expand All @@ -150,8 +157,8 @@ public static ValidateResult validateGroup(String group) {
return new ValidateResult(false, falseRemark);
}

if (group.length() > GROUP_MAX_LENGTH) {
String falseRemark = "The specified group: " + group + ", is longer than group max length: " + GROUP_MAX_LENGTH;
if (group.length() > groupMaxLength) {
String falseRemark = "The specified group: " + group + ", is longer than group max length: " + groupMaxLength;
return new ValidateResult(false, falseRemark);
}

Expand Down
21 changes: 21 additions & 0 deletions common/src/test/java/org/apache/rocketmq/common/topic/TopicValidatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,27 @@ public void testGroupValidator__NotPass() {
assertThat(res.isValid()).isFalse();
}

@Test
public void testGroupValidator_WithCustomMaxLength() {
try {
TopicValidator.setGroupMaxLength(255);
assertThat(TopicValidator.validateGroup(generateString2(255)).isValid()).isTrue();
assertThat(TopicValidator.validateGroup(generateString2(256)).isValid()).isFalse();

// values above 255 are capped at 255
TopicValidator.setGroupMaxLength(300);
assertThat(TopicValidator.validateGroup(generateString2(255)).isValid()).isTrue();
assertThat(TopicValidator.validateGroup(generateString2(256)).isValid()).isFalse();

// non-positive values fall back to the default of 120
TopicValidator.setGroupMaxLength(0);
assertThat(TopicValidator.validateGroup(generateString2(120)).isValid()).isTrue();
assertThat(TopicValidator.validateGroup(generateString2(121)).isValid()).isFalse();
} finally {
TopicValidator.setGroupMaxLength(120);
}
}

@Test
public void testAddSystemTopic() {
String topic = "SYSTEM_TOPIC_TEST";
Expand Down
Loading