[Ajax-1]

Which Issue(s) This PR Fixes

• Fixes [Bug] Timer metrics check logs Offset not matched for Long.MAX_VALUE when no eligible timer slot exists #11498

Brief Description

TimerWheel.checkPhyPos(readTimeMs, 0) returns Long.MAX_VALUE when no eligible slot exists in the timer wheel. TimerMessageStore.checkAndReviseMetrics() passed that sentinel straight to timerLog.getWholeBuffer(...), so MappedFileQueue.findMappedFileByOffset logged a misleading Offset not matched. Request offset: 9223372036854775807 ... warning whenever a TimerLog mapped file existed.

This PR makes the scan loop skip the sentinel (while (currOffsetPy != Long.MAX_VALUE)) instead of returning early, so the subsequent metrics revision still runs and small-topic counts are still reconciled (e.g. revised to 0 when the wheel is empty). Behavior for valid offsets is unchanged.

How Did You Test This Change?

Added two tests in TimerMessageStoreTest:

• testCheckAndReviseMetricsWithEmptyTimerWheel: TimerLog has an allocated mapped file and the wheel has no eligible slot; verifies getWholeBuffer(Long.MAX_VALUE) is never called and a stale metric (5) is revised to 0. This test fails without the fix.
• testCheckAndReviseMetricsWithValidSlot: enqueues two timer records into a valid slot; verifies the scan still works and a stale metric (5) is revised to 2.

Ran mvn -pl store test -Dtest='TimerMessageStoreTest,TimerWheelTest,TimerMetricsTest' locally: all passed (one pre-existing test is skipped on macOS by Assume), checkstyle passed.

[Ajax-1]

Hi, a note for reviewers: #11498 was closed by the reporter, but as far as I can tell the issue is still present on develop — checkAndReviseMetrics() still passes the Long.MAX_VALUE sentinel from TimerWheel.checkPhyPos into the TimerLog lookup. This PR fixes it and adds unit tests for the empty-wheel and valid-slot cases. @StiffCoconut, if it was closed by mistake, would you mind reopening it? Otherwise I'm happy to adjust this PR however the committers prefer. Thanks!

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.83%. Comparing base (592d59d) to head (fe2896a).

Additional details and impacted files

@@              Coverage Diff              @@
##             develop   #11499      +/-   ##
=============================================
- Coverage      49.89%   49.83%   -0.06%     
+ Complexity     14432    14411      -21     
=============================================
  Files           1391     1391              
  Lines         103362   103363       +1     
  Branches       13519    13520       +1     
=============================================
- Hits           51572    51515      -57     
- Misses         45596    45634      +38     
- Partials        6194     6214      +20     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Ajax-1]

Thanks for the review! The only failing check is bazel-compile, where PopPriorityIT failed (608/609 passed, including the timer store tests in store). It looks unrelated to this change: the test covers pop priority consumption and does not touch the timer store, and the same test has failed the same way on other unrelated branches (e.g. fix/heartbeat-syncer-orphan-unregister on Oct 27 and codex/receipt-handle-lock-lease today) and passed on rerun. Could you please re-run the failed job when you have a moment? Thanks!