fix(admin): limit swagger import response body size#6411
Open
SouthwestAsiaFloat wants to merge 1 commit into
Open
fix(admin): limit swagger import response body size#6411SouthwestAsiaFloat wants to merge 1 commit into
SouthwestAsiaFloat wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#6401
Description
This PR limits the Swagger/OpenAPI import response body size in shenyu-admin.
It adds a configurable
shenyu.swagger.max-body-sizesetting with a default value of 10 MB, rejects oversized Swagger responses both byContent-Lengthand during streaming, and returns HTTP 400 forinvalid or oversized import requests.
Tests
Added tests in:
SwaggerImportControllerTestSwaggerImportServiceImplTestThe tests cover oversized Swagger response rejection, HTTP 400 responses for invalid import requests, successful small-body imports, unknown
Content-Lengthstreaming limits, exact-limit bodies, emptyresponse bodies, and response charset handling.
Make sure that:
./mvnw clean install -Dmaven.javadoc.skip=true.