Repository navigation
[SPARK-55433][INFRA] Remove labeler in GitHub Actions - #54216
HyukjinKwon wants to merge 1 commit into
Conversation
|
Merged to master. |
### What changes were proposed in this pull request? This PR aims to remove `labeler` GitHub Action job. ### Why are the changes needed? To follow the Apache Spark main repository management. - apache/spark#54216 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manual review. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #500 from dongjoon-hyun/SPARK-55527. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
### What changes were proposed in this pull request? There might be a security issue. ### Why are the changes needed? Remove labeler.yml ### Does this PR introduce _any_ user-facing change? No, dev-only. ### How was this patch tested? Will monitor the CI. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#54216 from HyukjinKwon/SPARK-55433. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
This is a bit mysterious. Can you elaborate @HyukjinKwon? I was wondering why I was no longer seeing PR labels and realized the workflow was deleted. Dug through the history and found this PR. |
|
It was related to http://infra.apache.org/github-actions-policy.html |
|
Ah, looks like it was an issue with the That page links to this one, and though I have an old Confluence account that's still active, I get a "Page Not Found". Is it a permissions issue, or is that link broken for you too? I would like to follow-up with ASF INFRA about this as their current docs suggest the labeler workflow may be OK as long as nothing else uses the Is it OK with you if I contacted INFRA about this on behalf of the project? |
|
yeah .. I would like to get it back if possible ... I would appreciate it .. |
|
Filed a ticket here: https://issues.apache.org/jira/browse/INFRA-28094 |
|
The INFRA ticket doesn't seem like the right place to ask. These docs suggest Are you interested in starting a thread there to ask if it's OK to have a |
|
I actually sent some emails before but no responses .. |
|
Do you know if any committers are members of ASF Slack? Perhaps we could ask one of them to pop into It would be a lot simpler if we could just use the official labeler action with the appropriate guards vs. having to build something custom. |
### What changes were proposed in this pull request? Restore the labeler removed in [#54216](#54216) (SPARK-55433). - Run the official [`actions/labeler`](https://github.com/actions/labeler) every 10 minutes on PRs (both open and closed) updated since the last run of the labeler, plus a 10-minute overlap. Only write when labels change. - Sort and refresh the path rules, including new `DECLARATIVE PIPELINES` and `UDF` labels, which I have manually created. - Restore the `SCHEDULER`, `SHUFFLE`, and `BLOCK MANAGER` labels that we used to have. ### Why are the changes needed? Labels make it easier to find PRs by area. ASF is [disabling][asf] `pull_request_target` in November 2026, so we cannot restore the old workflow. [asf]: https://infra.apache.org/github-actions-policy.html This scheduled scan is much simpler than having a signal-based set of workflows or using some custom labeler action. The official GitHub labeler action runs from `master` without checking out PR code, including for PRs against maintenance branches. 1 workflow; no custom actions; no backports needed. For the initial labeling post merge, or to catch up after some kind of delay (e.g. GitHub Actions outage), committers can backfill labels using the command documented in the workflow. ### Does this PR introduce _any_ user-facing change? No. For contributors on GitHub only: PRs get area labels again, on a delay rather than immediately. Configured labels are kept in sync with changed files; unrelated labels such as `ai-review-requested` are preserved. The labeler config is authoritative and labels from that config applied manually will be removed by the action if they do not match its rules. ### How was this patch tested? Checked with ShellCheck and actionlint, suppressing only actionlint 1.7.12’s unrecognized `concurrency.queue` diagnostic. Local mocked-API tests against `actions/labelerv7` passed: 92 path cases, incremental and backfill PR selection, pagination, failure handling, label removal, preservation of unrelated labels, and zero writes on repeat runs. No writes were sent to GitHub. The scheduled trigger needs verification after merge, since it only runs from `master`. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: GitHub Copilot Closes #59862 from nchammas/restore-pr-labeler. Authored-by: Nicholas Chammas <nicholas.chammas@gmail.com> Signed-off-by: Nicholas Chammas <nicholas.chammas@gmail.com> skip-checks: true
What changes were proposed in this pull request?
There might be a security issue.
Why are the changes needed?
Remove labeler.yml
Does this PR introduce any user-facing change?
No, dev-only.
How was this patch tested?
Will monitor the CI.
Was this patch authored or co-authored using generative AI tooling?
No.