Repository navigation
[SPARK-60361][BUILD] Fix core module to use the root exec-maven-plugin version instead of 1.6.0 - #59609
Closed
dongjoon-hyun wants to merge 1 commit into
Closed
[SPARK-60361][BUILD] Fix core module to use the root exec-maven-plugin version instead of 1.6.0#59609dongjoon-hyun wants to merge 1 commit into
core module to use the root exec-maven-plugin version instead of 1.6.0#59609dongjoon-hyun wants to merge 1 commit into
Conversation
…ugin` version instead of `1.6.0`
Member
Author
|
Could you review this PR when you have some time, @sarutak ? |
sarutak
approved these changes
Oct 19, 2026
sarutak
left a comment
sarutak
left a comment
Member
There was a problem hiding this comment.
+1, LGTM. Thank you @dongjoon-hyun !
HyukjinKwon
approved these changes
Oct 19, 2026
Member
Author
|
Thank you, @sarutak and @HyukjinKwon ! |
Member
Author
|
I verified this manually. |
dongjoon-hyun
added a commit
that referenced
this pull request
Oct 19, 2026
…ugin` version instead of `1.6.0` ### What changes were proposed in this pull request? This PR aims to fix `core` module to use the root `exec-maven-plugin` version instead of the hard-coded `1.6.0`. ### Why are the changes needed? The `sparkr` profile in `core/pom.xml` overrides the root `exec-maven-plugin.version` (`3.6.1`) with the stale `1.6.0`. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs and manually check the effective POM. ``` $ build/mvn -q -N -f core/pom.xml -Psparkr help:effective-pom -Doutput=/dev/stdout | grep -A1 "<artifactId>exec-maven-plugin</artifactId>" ``` ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Opus 5.5 Closes #59609 from dongjoon-hyun/SPARK-60361. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit f5ebf00) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
added a commit
that referenced
this pull request
Oct 19, 2026
…ugin` version instead of `1.6.0` ### What changes were proposed in this pull request? This PR aims to fix `core` module to use the root `exec-maven-plugin` version instead of the hard-coded `1.6.0`. ### Why are the changes needed? The `sparkr` profile in `core/pom.xml` overrides the root `exec-maven-plugin.version` (`3.6.1`) with the stale `1.6.0`. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs and manually check the effective POM. ``` $ build/mvn -q -N -f core/pom.xml -Psparkr help:effective-pom -Doutput=/dev/stdout | grep -A1 "<artifactId>exec-maven-plugin</artifactId>" ``` ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Opus 5.5 Closes #59609 from dongjoon-hyun/SPARK-60361. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit f5ebf00) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
added a commit
that referenced
this pull request
Oct 19, 2026
…ugin` version instead of `1.6.0` ### What changes were proposed in this pull request? This PR aims to fix `core` module to use the root `exec-maven-plugin` version instead of the hard-coded `1.6.0`. ### Why are the changes needed? The `sparkr` profile in `core/pom.xml` overrides the root `exec-maven-plugin.version` (`3.6.1`) with the stale `1.6.0`. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs and manually check the effective POM. ``` $ build/mvn -q -N -f core/pom.xml -Psparkr help:effective-pom -Doutput=/dev/stdout | grep -A1 "<artifactId>exec-maven-plugin</artifactId>" ``` ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Opus 5.5 Closes #59609 from dongjoon-hyun/SPARK-60361. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit f5ebf00) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
added a commit
that referenced
this pull request
Oct 19, 2026
…ugin` version instead of `1.6.0` ### What changes were proposed in this pull request? This PR aims to fix `core` module to use the root `exec-maven-plugin` version instead of the hard-coded `1.6.0`. ### Why are the changes needed? The `sparkr` profile in `core/pom.xml` overrides the root `exec-maven-plugin.version` (`3.6.1`) with the stale `1.6.0`. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs and manually check the effective POM. ``` $ build/mvn -q -N -f core/pom.xml -Psparkr help:effective-pom -Doutput=/dev/stdout | grep -A1 "<artifactId>exec-maven-plugin</artifactId>" ``` ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Opus 5.5 Closes #59609 from dongjoon-hyun/SPARK-60361. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit f5ebf00) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
added a commit
that referenced
this pull request
Oct 19, 2026
…ugin` version instead of `1.6.0` ### What changes were proposed in this pull request? This PR aims to fix `core` module to use the root `exec-maven-plugin` version instead of the hard-coded `1.6.0`. ### Why are the changes needed? The `sparkr` profile in `core/pom.xml` overrides the root `exec-maven-plugin.version` (`3.6.1`) with the stale `1.6.0`. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs and manually check the effective POM. ``` $ build/mvn -q -N -f core/pom.xml -Psparkr help:effective-pom -Doutput=/dev/stdout | grep -A1 "<artifactId>exec-maven-plugin</artifactId>" ``` ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Opus 5.5 Closes #59609 from dongjoon-hyun/SPARK-60361. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit f5ebf00) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to fix
coremodule to use the rootexec-maven-pluginversion instead of the hard-coded1.6.0.Why are the changes needed?
The
sparkrprofile incore/pom.xmloverrides the rootexec-maven-plugin.version(3.6.1) with the stale1.6.0.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs and manually check the effective POM.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 5.5