Repository navigation
fix(runtime): SELinux-safe start on Podman, VM socket for Docker on desktops - #1495
Merged
Pijukatel merged 2 commits intoOct 13, 2026
Merged
Conversation
…forces it Under SELinux enforcing - Fedora and RHEL, and the Fedora-based VM of `podman machine`, so Podman Desktop on macOS and Windows - the runtime container may not connect to the engine's API socket bind-mounted into it: the socket carries the engine's label, not a container's. The runtime does everything through that socket, so `apify runtime start` produced a runtime that reported the engine as unavailable. `podmanInfo` now also reads `Host.Security.SELinuxEnabled`, and `buildRuntimeRunArgs` adds `--security-opt label=disable` (via the new `runtimeSecurityOptions`, next to `runtimeNetworkMode`) when it is set. Only the runtime container runs unconfined; the Actor containers it starts stay confined as before. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013oHHo44jxAVWrVrBvf2DBk
`resolveEngineSocketPath` now ignores `DOCKER_HOST` off Linux, so the rootless-Docker case has to say which platform it means: on the Windows runners it took the host platform and got the default socket back. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013oHHo44jxAVWrVrBvf2DBk
Pijukatel
marked this pull request as ready for review
October 13, 2026 09:18
Pijukatel
pushed a commit
to apify/actor-runtime
that referenced
this pull request
Oct 13, 2026
…art command apify-cli's `buildRuntimeRunArgs` now adds `--security-opt label=disable` itself on Podman hosts with SELinux enforcing (apify/apify-cli#1495), placed after the network mode. Move the suite's own `extraRunArgs` escape hatch into the mirrored `runtimeRunArgs` at that same position, so the pinned command is once again the CLI's verbatim, and pin the new shape in the unit test. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013oHHo44jxAVWrVrBvf2DBk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two cases where
apify runtime startproduced a runtime that reported the engine as unavailable. Both surfaced on actor-runtime's macOS CI leg (apify/actor-runtime#65).SELinux on Podman hosts
podman machine, so Podman Desktop on macOS and Windows), the runtime container may not connect to the engine's API socket bind-mounted into it: the socket carries the engine's label, not a container's.podmanInfonow also readsHost.Security.SELinuxEnabled;buildRuntimeRunArgsadds--security-opt label=disablevia the newruntimeSecurityOptions, next toruntimeNetworkMode.Docker socket on macOS and Windows
/var/run/docker.sockinside it on every desktop engine. ADOCKER_HOSTunix socket is a host path (Colima's docs suggest exporting one for tools that ignore contexts), which a bind mount cannot carry into the VM.resolveEngineSocketPathnow consultsDOCKER_HOSTonly on Linux.