Repository navigation
Conversation
…and apify-client-js changes Syncs to OpenAPI spec v2-2026-10-19T133704Z (apify-docs#3087 request-schema changes needed no code change: every mutating call already takes an arbitrary JSON-serializable object) and to apify-client-js#1140, #1145, #1139, #1141, #1152: - Added ApifyClientException, a common base ApifyApiException/ApifyTransportException now extend, so catch (ApifyClientException) catches every client-raised error. - Added SetRecordOptions.ContentEncoding for uploading already-compressed key-value-store records. - Added DatasetClient.StreamItemsAsync for streaming a dataset item export instead of buffering it. - Added LogClient.GetBytesAsync for fetching a log as raw bytes instead of a decoded string. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G3FfQf9r45KVCa5VAYAjkd
… as checked Round 2 fix for the review's two open items: - apify-client-js#1142 (chunkSize on listKeys()/listRequests() iterators): the request-queue side was already covered by the existing PaginateRequestsAsync/MaxPageLimit. Adds the missing key-value-store side: KeyValueStoreClient.IterateKeysAsync, an auto-paging iterator over a store's keys with a new IterateKeysOptions (Limit across pages, MaxPageLimit per page - never sent to the API, matching chunkSize - ExclusiveStartKey, Collection, Prefix). - apify-client-js#1144 (pricingInfos/exampleRunInput on ActorUpdateOptions): recorded as checked, no code change needed (ActorClient.UpdateAsync(object) already passes any fields through). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G3FfQf9r45KVCa5VAYAjkd
Round 3 fix for the review's open item: the API reads limit=0 as unbounded, not zero, so Limit=0 (or an already-exhausted total) now short-circuits before building any request instead of sending 0 and yielding whatever the API returns regardless. MaxPageLimit must now be positive for the same reason (a literal 0 would hit the same API quirk). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G3FfQf9r45KVCa5VAYAjkd
apify-service-account
added
the
tested
apify-service-account
added
the
t-tooling
Collaborator
Author
|
Superseded by #18, which carries the same commits plus two Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs to OpenAPI spec
v2-2026-10-19T133704Z(apify-docs#3087) and to apify-client-js changes merged since the last sync (apify-client-js#1140, #1145, #1139, #1141, #1152, #1142, #1144).apify-docs#3087's request-schema changes (
CreateActorRequestgainsactorPermissionLevel;CreateOrUpdateVersionRequestsplits intoCreateVersionRequest/UpdateVersionRequest;EnvVarRequestbecomes standalone;ScheduleNotificationsis extracted) needed no code change: every mutating call in this client already accepts an arbitrary JSON-serializable object, so the API already accepts every field these schema changes describe.Changes:
ApifyClientException, a common baseApifyApiException/ApifyTransportExceptionnow extend, socatch (ApifyClientException)catches every error this client raises for a failed call (apify-client-js#1145).SetRecordOptions.ContentEncodingfor uploading an already-compressed key-value-store record: sent verbatim as theContent-Encodingheader, skipping the client's own compression (apify-client-js#1140).DatasetClient.StreamItemsAsyncfor streaming a dataset item export instead of buffering it into abyte[](apify-client-js#1139/#1152).LogClient.GetBytesAsyncfor fetching a log as raw bytes instead of a decoded string (apify-client-js#1141).KeyValueStoreClient.IterateKeysAsync(+IterateKeysOptions), an auto-paging iterator over a store's keys with a per-pageMaxPageLimit, matching the reference client's chunkedlistKeys()iteration (apify-client-js#1142).Limit = 0yields no keys without issuing any request, since the API itself reads a literallimit=0as unbounded rather than zero;MaxPageLimitmust be positive for the same reason.pricingInfos/exampleRunInputonActorUpdateOptions) needed no code change —ActorClient.UpdateAsync(object)already passes any fields through.Bumped
ApifyClientVersion.ApiSpecVersiontov2-2026-10-19T133704Zand the project version to0.6.0. Updateddocs/README.md,docs/storages.md,docs/misc.md, andCHANGELOG.md.Verification:
dotnet format --verify-no-changesclean,dotnet build -c Release0 warnings/0 errors,dotnet test --filter Category=Unit191/191 passing,dotnet test --filter "Category=Integration|Category=Examples"67/67 passing against the live API.Reviewed through three rounds by
/review-client(dev-diary notes kept in the orchestration repo's working copy, archived separately); all open items were fixed and verified, final verdictReviewer: Approved.Generated by Claude Code