Repository navigation
Conversation
…-client-js - KeyValueStoreClient.SetRecordRawWithEncoding: upload an already-compressed record under an explicit Content-Encoding, skipping the client's own request compression (ports apify-client-js #1140). - LogClient.GetBuffer/GetBufferWithOptions: raw-bytes counterpart of Get (ports apify-client-js #1141). - DatasetClient.DownloadItemsStream: streaming counterpart of DownloadItems, sharing a new streamRaw helper with LogClient.StreamWithOptions (ports the net effect of apify-client-js #1139/#1152). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G3FfQf9r45KVCa5VAYAjkd
Pijukatel
added
adhoc
Claude
…m port
- Qualify callPreEncoded/putRawWithEncoding/SetRecordRawWithEncoding godoc:
an empty contentEncoding still unconditionally skips the client's own
request compression, unlike call/putRaw/SetRecordRaw. Add a unit test
pinning that a >=1024-byte body is sent uncompressed either way.
- Add KeyValueStoreClient.GetRecordStream/GetRecordStreamWithOptions, the
reference client's missing getRecord({ stream: true }) counterpart, on
top of the shared streamRaw helper (now also returns headers so a
stream caller can read Content-Type).
- Align DatasetClient.DownloadItems to mergedParams, matching its
DownloadItemsStream sibling and the rest of the resourceContext helpers.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01G3FfQf9r45KVCa5VAYAjkd
apify-service-account
added
the
tested
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the Go-relevant reference-client changes from the latest
apify-client-jsbatch (apify/apify-client-js#1140, #1141, #1139, #1152) into the Go client. No OpenAPI spec update is pending, soAPISpecVersionis unchanged.KeyValueStoreClient.SetRecordRawWithEncoding: uploads an already-compressed record under an explicitContent-Encoding(gzip/br/deflate), skipping the client's own request compression so the value is never compressed twice (apify-client-js#1140).LogClient.GetBuffer/GetBufferWithOptions: raw-bytes counterpart ofGet(apify-client-js#1141).DatasetClient.DownloadItemsStream: streaming counterpart ofDownloadItems, sharing a newstreamRawbase helper withLogClient.StreamWithOptions(ports the net effect of apify-client-js#1139, superseded by #1152, which foldedstreamItems()into astreamoption ondownloadItems()).KeyValueStoreClient.GetRecordStream/GetRecordStreamWithOptions: streaming counterpart ofGetRecord, matching the reference client'sgetRecord(key, { stream: true })(added during review for reference-client parity; also built onstreamRaw).apify-client-js#1145 (a common
ApifyClientErrorbase class) was evaluated and not ported: Go has no exception hierarchy to unify,APIErroris already the client's single error type, and theIs*status predicates already serve as the idiomatic equivalent (seeCHANGELOG.md[0.10.0]).CHANGELOG.md,docs/storages.md,docs/misc.mdupdated;ClientVersionbumped0.11.0→0.12.0.