Repository navigation
chore: define the online evals rubric and score configs - #1
Merged
Merged
Conversation
RobertCrupa
added this pull request to stack #6
September 9, 2026 15:14
RobertCrupa
force-pushed
the
feat/online-evals-rubric
branch
from
October 7, 2026 09:00
1069876 to
d8914e3
Compare
RobertCrupa
removed this pull request from stack #6
October 7, 2026 09:08
RobertCrupa
added this pull request to stack #26
October 7, 2026 09:08
apify-service-account
added
the
tested
vojtechj-apify
approved these changes
Oct 7, 2026
vojtechj-apify
left a comment
vojtechj-apify
left a comment
There was a problem hiding this comment.
Looks good. The rubric, the derived score names and the 35-character assertion all check out, and splitting the score-config script into a pure plan plus I/O makes it easy to trust. One comment on the script below.
The apify-pull-request-toolkit check is failing. I couldn't open its log. Can you check it isn't a missing label or issue link?
Online evals (ai-team#268) need the score schema fixed before anything
judges, because Langfuse score configs can only be archived, never deleted.
- src/rubric.ts: ONLINE_RUBRIC { name: 'apify-ai-turn', version: 1 } with
six PASS/FAIL criteria and a separate holistic verdict (not derived from
taskCompletion, per ai-team#269); score names agent_judge and
agent_judge_<criterion> derived from the rubric; 35-char cap and charset
asserted at import time.
- src/score-configs.ts: one BOOLEAN desired config per name and the pure
create plan (create / exists / conflict on dataType mismatch or archived).
- scripts/create-score-configs.ts: idempotent I/O around the plan, run via
`npm run create-score-configs --workspace actors/judge`. Not executed.
- test/: vitest for the rubric shape, name derivation, the cap and the plan.
- README: online rubric, score semantics, why BOOLEAN, archive-only configs.
- errorRecovery is not scored on turns without a tool error (ai-team#269); the rubric text and README row no longer count "no error" as a PASS. - Conflict plan entries list every same-name config (id, dataType, archived) instead of naming only the first one. - Add tsconfig.check.json and `npm run typecheck` covering src, scripts and test with noEmit; the build tsconfig is unchanged.
RobertCrupa
force-pushed
the
feat/online-evals-rubric
branch
from
October 8, 2026 12:54
d8914e3 to
3fa3f71
Compare
Contributor
Author
|
@vojtechj-apify you're right, the issues this closes is outside this repo so i will add the ad-hoc lable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes apify/ai-team#268. Part of apify/ai-team#249 (online evals), stacked on `main` (rebased 2026-10-07; the PoC landed on main as #7 to #13).
Deviations from the issue text, on purpose:
Offline `datasetRun` mode is untouched.